lncli: Print help text in case of encrypted wallet. #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
encrypted-wallet-helptext
branch
from
2364646 to
46e0fbf
Compare
This commit adds a decorator that will inspect the error from an command action, and prints an encrypted wallet help text if the error has status code Unimplemented. This is done to help a user that is trying to issue lncli commands before unlocking the wallet, since the RPC server won't be active and every call will return this status code.
halseth
force-pushed
the
encrypted-wallet-helptext
branch
from
46e0fbf to
d1e39e7
Compare
cfromknecht
approved these changes
Nov 11, 2017
|
|
||
| // actionDecorator is used to add additional information and error handling | ||
| // to command actions. | ||
| func actionDecorator(f func(*cli.Context) error) func(*cli.Context) error { |
Roasbeef
approved these changes
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit inspects the error from an RPC call, and
prints an encrypted wallet help text if the error has
status code Unimplemented. This is done to help a user
that is trying to issue lncli commands before unlocking
the wallet, since the RPC server won't be active and
every call will return this status code.
I chose not to explain the
--noencryptwalletoption,as we want to move towards users encrypting their wallets.