lnwallet: Add 2nd-stage htlc size constants and outgoing GenWitnessFunc #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
force-pushed
the
lnwallet-htlc-witness
branch
3 times, most recently
from
21fdcdc to
47c419e
Compare
cfromknecht
force-pushed
the
lnwallet-htlc-witness
branch
from
47c419e to
f9c600e
Compare
|
These commits were merged in with #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is being split from #384, and adds most of the wallet features required to sign outgoing HTLCs that will be incubated in the utxo nursery. The constants are derived from prior calculations made in BOLT-05.
We create a separate, public method for signing htlc success transactions so that it matches the same signature of our other witness generation functions. The txn version, sig cache, and sequence number are already set by the caller in the context of the onchain subsystems.