Add detailed balance info to WalletBalance RPC

[nalinbhardwaj]

Replaces current balance field by 3 fields, TotalBalance, ConfirmedBalance and UnconfirmedBalance to store the respective balance information.

Closes #415.

[mlerner]

I'm doing a first pass review of this to help out with the review backlog. This PR looks mostly good to me, with a few nits.

[mlerner]

nit: make TotalBal => totalBal because this is an intermediate variable.

[mlerner]

nit: make ConfirmedBal => confirmedBal because this is an intermediate variable.

[mlerner]

I think this TODO needs to be added back - it is not implemented or in scope for this PR.

[mlerner]

Two other things: you will need to rebase your branch with master to resolve, and also reformat commit messages, as mentioned in the style guide -
https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#44-model-git-commit-messages

All commits should begin with the subsystem or package primarily affected by the change - in this case you could split up your commits into proto (for the *.proto changes) and lncli for code that uses those changes.

[nalinbhardwaj]

@mlerner : I think I've addressed all changes you mentioned now. Thanks for letting me know. I'll do similar changes with #417 commit messages as well. :)

Note: Seems like the travis build is failing for unrelated reasons.

[Roasbeef]

Thanks for the PR!

Tested locally and works as advertised. I just have some minor nits w.r.t to the coding style prescribed within the repo. Once those nits are addressed, I'll get this merged!

[Roasbeef]

Nit: missing a period here, and the comments below.

All comments should be full sentences.

[Roasbeef]

Initial line should be modified to read something like:

WalletBalance returns total unspent outputs (confirmed and unconfirmed), all

[nalinbhardwaj]

@Roasbeef : Addressed the nits, sorry about those.

[Roasbeef]

Hey @nalinbhardwaj, can you rebase this? A recent PR went in that also modified the protos. You'll just need to rebuild them.

[nalinbhardwaj]

@Roasbeef done. Not sure why there’s a commit you made “with me” though? I don’t see a way to remove that offline, let me know if that’s a problem.

[Roasbeef]

@nalinbhardwaj you'll need to remove that last commit. When rebasing you should ensure that your master branch is up to date with the remote origin branch.

[nalinbhardwaj]

Done now @Roasbeef sorry about the weird error, not sure why I got that into commit history in first attempt. It's clean now.

[Roasbeef]

Is your PGP key available on any public key server?

[Roasbeef]

LGTM 🎉

[nalinbhardwaj]

@Roasbeef I have it on keybase