Skip to content

Conversation

Roasbeef
Copy link
Member

Recently we've received many questions about what macroons, how they work, how they're used in lnd, and our future plans for this. This PR adds a new section to the documentation explaining mcaroons written by @aakselrod.

Copy link
Contributor

@aakselrod aakselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the --macaroonip addition, this LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already available using --macaroonip switch for lncli.

@Roasbeef Roasbeef removed the request for review from halseth November 27, 2017 23:35
aakselrod
aakselrod previously approved these changes Nov 27, 2017
aakselrod
aakselrod previously approved these changes Nov 27, 2017
Copy link
Contributor

@aakselrod aakselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cfromknecht
Copy link
Contributor

this is a super helpful addition to the docs 👍 well written and thorough, nice work!

Copy link
Contributor

@aakselrod aakselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again.

@aakselrod aakselrod merged commit e572c54 into lightningnetwork:master Nov 28, 2017
@halseth
Copy link
Contributor

halseth commented Nov 28, 2017

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants