channeldb: update channeldb to set and store SettleDate for invoices #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlerner
force-pushed
the
ml/settle-date
branch
from
40b2cfe to
907b87d
Compare
mlerner
force-pushed
the
ml/settle-date
branch
from
907b87d to
3437835
Compare
mlerner
commented
Dec 5, 2017
| fallbackAddr = decoded.FallbackAddr.String() | ||
| } | ||
|
|
||
| settleDate := int64(0) |
There was a problem hiding this comment.
The Unix timestamp for the zero value of time.Time is -62135596800, which I think is not as friendly as a default of 0.
Roasbeef
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits that resolve a TODO from
channeldb/invoices.go: https://github.com/lightningnetwork/lnd/compare/master...mlerner:ml/settle-date?expand=1#diff-9f84ce21f17bb10010b2d2b19cb17e3cL421SettleDateto the channeldb representation of an invoice.SettleDatestored in the database to the RPC representation of an invoice.