lncfg: add IPv6 resolution bypass & account for local hostname aliases #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, if --tor.active is specified, then IPv6 addresses will no longer go through the connmgr.TorLookupIP function from btcd. This function does not have proper IPv6 support and would fail with the error "tor general error". Instead, use the system resolver.
In this commit, we fix a bug that would cause resolution of items in /etc/hosts (or the like) to fail as Tor wouldn't recognize them as proper host names. With this commit, we'll catch this error and fall back to the system's resolver.
|
This is mainly a short term fix, once this lands we should modify btcd's |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4988