DynComms [4/n]: Implement Dynamic Commitments Negotiation #8756
Commits on Oct 14, 2024
-
htlcswitch: define state machine for quiescence
htlcswitch: add drive method to quiescer
-
htlcswitch: implement stfu response
htlcswitch: use quiescer drive method in link stfu implementation This commit amends the implementation presented in the last one by taking advantage of the quiescer drive method. This allows us to centralize quiescence logic better rather than diffusing it throughout the link. h/t @carlaKC
-
-
-
-
-
-
-
-
-
-
htlcswitch: defer processRemoteAdds when quiescent
In this commit we defer processRemoteAdds using a new mechanism on the quiescer where we capture a closure that needs to be run. We do this because we need to avoid the scenario where we send back immediate resolutions to the newly added HTLCs when quiescent as it is a protocol violation. It is not enough for us to simply defer sending the messages since the purpose of quiescence itself is to have well-defined and agreed upon channel state. If, for whatever reason, the node (or connection) is restarted between when these hooks are captured and when they are ultimately run, they will be resolved by the resolveFwdPkgs logic when the link comes back up. In a future commit we will explicitly call the quiescer's resume method when it is OK for htlc traffic to commence.
-
htlcswitch: implement noop quiescer
In this commit we implement a noop quiescer that we will use when the feature hasn't been negotiated. This will make it far easier to manage quiescence operations without having a number of if statements in the link logic.
-
htlcswitch+peer: allow the disabling of quiescence
Here we add a flag where we can disable quiescence. This will be used in the case where the feature is not negotiated with our peer.
-
-
-
-
-
-
-
-
-
channeldb+lnwallet: add epoch history to OpenChannel
This commit takes the CommitChainEpochHistory defined in the last commit and adds it to the OpenChannel structure. As of this commit it is essentially redundant with the ChanCfgs but it will capture the history of the ChanCfgs when we add the ability to update them.
-
lnwallet: use CommitChainEpochHistory to determine CsvDelay during Br…
…each This commit changes the way we create breach retributions to use the CsvDelay we compute from the CommitChainEpochHistory so as to account for the possibility that the channel parameters have changed since opening.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.