Importmap support #1135
Merged
Importmap support #1135
+108
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
importmap
branch
from
f6e80d1 to
cd9466d
Compare
bcardarella
reviewed
Oct 9, 2025
karlseguin
reviewed
Oct 10, 2025
| pub fn resolveSpecifier(self: *ScriptManager, arena: Allocator, _specifier: []const u8, base: []const u8) ![:0]const u8 { | ||
| var specifier = _specifier; | ||
| // If the specifier is mapped in the importmap, use it to resolve the path. | ||
| if (self.importmap.get(specifier)) |s| { |
There was a problem hiding this comment.
I would expect the URLs in the import map to be resolved based on the document's URL and not the referrer of the module. If that's the case, then
1 - When populating importmap, the imports need to be resolved against page.url
2 - In this function, when found, it should be returned directly from the map
There was a problem hiding this comment.
Should be fixed now
Co-authored-by: Karl Seguin <karlseguin@users.noreply.github.com>
krichprollsch
force-pushed
the
importmap
branch
from
6ebae5f to
acf06fd
Compare
karlseguin
approved these changes
Oct 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1129