Updates to lightspark-sdk, core, ui #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
# Design fixes for 3a onboarding / link bank This addresses several design requests from a recent design review: Link bank 1. add an 8px left margin to align with title and input box 2. set a min height 3. group "about iban" with bottom button 4. use bridge modal for iban bank info on Verify3aIdentity 1. remove the back button 2. set border radius and border width on birthday input GitOrigin-RevId: c243af24b20620cf01718c1415dc3898a116ad1e
|
The following public packages have changed files:
There are 3 existing changesets for this branch. If additional changes have been made that require different versions for any package simply add another changeset. Any packages that depend on the planned releases will be updated and released automatically in a separate PR. Each changeset corresponds to an update in the CHANGELOG for the packages listed in the changeset. Therefore, you should add a changeset for each noteable package change that this PR contains. For example, if a PR adds two features - one feature for packages A and B and one feature for package C - you should add two changesets. One changeset for packages A and B and one changeset for package C, with a description of each feature. The feature description will end up being the CHANGELOG entry for the packages in the changeset. The following releases are planned based on the existing changesets:
Last updated by commit 93ce011 |
GitOrigin-RevId: 01278048d8d810d6cc99a069886c78463543c57e
This PR: - Updates BridgeCardForm/Add-credential to check is_shadow search param - Makes BirthdayInput text size per spec - Makes EntBridgeUserExample default to is_shadow is false for tests GitOrigin-RevId: 11141e9265731a824e0e17d0a0875d91c883892c
GitOrigin-RevId: a38c4e1e23d85ce9dbfd0e43fe1a46118786ec26
…rs (#18149)
# UMA Activation UI Enhancements
This PR improves the UMA activation experience with several UI updates:
- Added a new "Confirm your phone" onboarding step with appropriate icon and translations
- Enhanced the UMA card with a new activation banner showing completion progress
- Updated welcome messaging to be more inviting ("Welcome to UMA!" instead of "Complete Setup")
- Improved the onboarding progress modal with:
- Changed button text from "Get Started" to "Continue"
- Added "In Progress" status indicator for current steps
- Updated modal title to "Activate your UMA" for clarity
- Added new translations for all new UI elements in English, Spanish, and Portuguese
- Refined styling for various UI components including rounded corners and consistent spacing
GitOrigin-RevId: 9e9b291a7137b2f67ad2ac5c8036dc207f152f74
GitOrigin-RevId: 76b711f021ad7182c620fe9562ef05686af00a23
### TL;DR
Added support for creating UMA invitations with attached payments.
### What changed?
- Added a new GraphQL mutation `CreateUmaInvitationWithPayment.ts` that allows creating UMA invitations with an attached payment
- Implemented a new client method `createUmaInvitationWithPayment()` in the LightsparkClient class that accepts:
- inviterUma (string)
- amountToSend (object with amount and currency details)
- expiresAt (string or Date)
- Added proper error handling and type conversion for the new method
### How to test?
Test the new functionality by calling the `createUmaInvitationWithPayment()` method with valid parameters:
```typescript
const invitation = await client.createUmaInvitationWithPayment(
"uma@example.com",
{
amount: 1000, // amount in cents
currency: {
code: "USD",
symbol: "$",
name: "US Dollar",
decimals: 2
}
},
new Date(Date.now() + 86400000) // expires in 24 hours
);
```
Verify that the returned invitation object contains the expected payment details.
### Why make this change?
This enhancement allows users to create UMA invitations with payments attached, enabling a more seamless onboarding experience where new users can receive funds as part of their invitation. This feature expands the functionality of the UMA invitation system and provides more flexibility for application developers.
GitOrigin-RevId: b322a58977f940ddd5d49faa0dbd08940cf056e3
### TL;DR Added functionality to cancel UMA invitations in the Lightspark SDK. ### What changed? - Added a new `cancelUmaInvitation` method to the `LightsparkClient` class that allows canceling UMA invitations by their invite code - Created a new GraphQL mutation file `CancelUmaInvitation.ts` that defines the mutation for canceling UMA invitations - Imported the new mutation in the client file ### How to test? 1. Create a UMA invitation using the existing SDK methods 2. Call the new `cancelUmaInvitation` method with the invitation code 3. Verify that the invitation is successfully canceled and the method returns the canceled invitation object 4. Try to claim the canceled invitation and confirm it fails ### Why make this change? This change provides users with the ability to cancel UMA invitations that were previously created but are no longer needed. This completes the UMA invitation lifecycle management in the SDK, which already supported creating and claiming invitations. GitOrigin-RevId: df6edac150e6443f6a020d77fb37bbaa4a616bdb
GitOrigin-RevId: 033289ee54c0aeb55422589e986923593c5cfa0a
  GitOrigin-RevId: fbaaa90c14ca2c2fe4f3379d91310836fd8aa713
coreymartin
changed the title
JasonCWang
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change should result in new package versions please add a changeset before merging. You can do so by clicking the link provided by changeset bot below.