Updates to core, ui, lightspark-sdk #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
## Reason In order to enforce name matching in the MX onboarding flow, we need to add a pending page and different landing pages depending on the name matching result. This PR adds the pending page when the GK is enabled. Design: https://www.figma.com/design/hb8mqsg0n3QKJHpJA0ahkI/MXN-Grid-Switch?node-id=17-15925&m=dev Screenshots below:   GitOrigin-RevId: 16f902a477add267300b15f73f2420bbadccbd53
|
The following public packages have changed files:
There are 3 existing changesets for this branch. If additional changes have been made that require different versions for any package simply add another changeset. Any packages that depend on the planned releases will be updated and released automatically in a separate PR. Each changeset corresponds to an update in the CHANGELOG for the packages listed in the changeset. Therefore, you should add a changeset for each noteable package change that this PR contains. For example, if a PR adds two features - one feature for packages A and B and one feature for package C - you should add two changesets. One changeset for packages A and B and one changeset for package C, with a description of each feature. The feature description will end up being the CHANGELOG entry for the packages in the changeset. The following releases are planned based on the existing changesets:
Last updated by commit 11e36a5 |
Update public `js` sources with the latest code from the [public repository](https://github.com/lightsparkdev/js-sdk) main branch. This typically happens when new versions of the SDK are released and version updates need to be synced. The PR should be merged as soon as possible to avoid updates to webdev overwriting the changes in the js-sdk develop branch. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lightspark Eng <engineering@lightspark.com> Co-authored-by: Peng Ying <peng@lightspark.com> GitOrigin-RevId: e30a45111187be96d3583658bd02bb271521e53f
  GitOrigin-RevId: fd51392ec1ad6c61ea11a55e4810cf5ff0bce6df
  GitOrigin-RevId: 8a5e2a6ef5f2d08ce7ea2ce14fe9fc59a4cfb714
## Reason Add "fun facts" while users wait for their kyc to complete ## Overview This re-uses the same fun facts component from LinkBankMX ## Test Plan KYC a user - while their kyc is in pending state, we should see the following screen, complete with fun facts  GitOrigin-RevId: fe6335c827bd3110d2915b288da66b6de04d3e11
 GitOrigin-RevId: 6388684ba3bcce5fad01df8fbbb3621f23691c04
## Reason Typically we have this circular-deps check for JS packages but it was never added to this one. I realized it's causing a downstream issue so this adds the check and resolves circular deps. GitOrigin-RevId: 1ea0bf0d6f3c7f48a38527f971cb9c32c90b6a7a
## Reason Typically we have this circular-deps check for JS packages but it was never added to this one. I realized it's causing a downstream issue so this adds the check and resolves circular deps. GitOrigin-RevId: cc9081a0419495600c89ebec1d9e4c8ff6b5c9b3
## Reason It's not exactly clear when this became an issue for spark-sdk on React Native because originally it was working fine with a dynamic import. Somewhere along the way, possibly due to an updated dependency in spark/js lock file, it started causing the following error: <img width="479" height="377" alt="Screenshot 2025-08-21 at 11 27 57 PM" src="https://github.com/user-attachments/assets/206d254b-b721-4c84-b93c-559f3039a042" /> We need to avoid referencing ws in React Native entrypoints which resolves the issue. GitOrigin-RevId: 8e9297ac7c1d096d90fd0f46096187cc92256c2b
coreymartin
changed the title
coreymartin
changed the title
bsiaotickchong
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change should result in new package versions please add a changeset before merging. You can do so by clicking the link provided by changeset bot below.