Uma data visibility #174
Merged
Uma data visibility #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklein24
reviewed
Jun 25, 2024
lightspark-sdk/src/commonJvmAndroidMain/kotlin/com/lightspark/sdk/LightsparkFuturesClient.kt
Outdated
Show resolved
Hide resolved
lightspark-sdk/src/commonJvmAndroidMain/kotlin/com/lightspark/sdk/LightsparkFuturesClient.kt
Outdated
Show resolved
Hide resolved
lightspark-sdk/src/commonMain/kotlin/com/lightspark/sdk/LightsparkCoroutinesClient.kt
Outdated
Show resolved
Hide resolved
|
|
||
| fun hashUmaIdentifier(identifier: String, signingPrivateKey: ByteArray): String { | ||
| val now = getUtcDateTime() | ||
| val input = identifier.toByteArray() + "${now.monthNumber}-${now.year}".toByteArray() + signingPrivateKey |
jklein24
reviewed
Jun 25, 2024
| ${'$'}amountMsats: Long! | ||
| ${'$'}metadataHash: String! | ||
| ${'$'}expirySecs: Int = null | ||
| ${'$'}receiverHash: String |
There was a problem hiding this comment.
Does this need an = null too?
jklein24
reviewed
Jun 25, 2024
| ${'$'}amountMsats: Long! | ||
| ${'$'}metadataHash: String! | ||
| ${'$'}expirySecs: Int = null | ||
| ${'$'}receiverHash: String |
There was a problem hiding this comment.
it seems like not needed?? for example https://github.com/lightsparkdev/kotlin-sdk/pull/174/files#diff-a3974086a91f49faa928b13e5e700377265b59a374ebf9e127ccb428e27e55f1R11 but updated anyways
jklein24
approved these changes
Jun 25, 2024
shreyav
added a commit
that referenced
this pull request
Jul 9, 2024
* lnurlp fallback * annotation and tests * fallback sender side * fix serialization * unused import * comments * fixes * Try to fix docs publish job my running on main * [gha] Use environment for doc-publish * Fix sender vasp utxo callback * Switch to a full 64bit nonce * Use json for parsing in demo vasp (#163) * Update the demo VASP's SDK version to 0.8.0 * Update the demo VASP's SDK version to 0.8.1 * Accept gzip responses, compress request with deflate (#172) Install `ContentEncoding` plugin to handle gzip responses. Compress requests larger than 1K using `Deflater`. Change `addSigningDataIfNeeded()` to return serialised bytes so that we only serialise once. * Regenerate SDK (#173) * Regenerate SDK * no op vls * Update macos environment version (#175) * Uma data visibility (#174) * fix typo (#176) * encode hex (#177) * Bump lightspark-sdk to version 0.14.0 * Load signing key * Revert "Merge release/lightspark-sdk-v0.14.0 into develop" (#181) * Bump lightspark-sdk to version 0.14.0 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shreyav <shreya@lightspark.com> Co-authored-by: Jeremy Klein <jklein24@gmail.com> Co-authored-by: Michael Gorven <michael@gorven.net> Co-authored-by: Michael Gorven <mgorven@lightspark.com> Co-authored-by: runner <runner@Mac-1720545346122.local> Co-authored-by: runner <runner@Mac-1720552895732.local>
shreyav
added a commit
that referenced
this pull request
Jul 16, 2024
* lnurlp fallback * annotation and tests * fallback sender side * fix serialization * unused import * comments * fixes * Try to fix docs publish job my running on main * [gha] Use environment for doc-publish * Fix sender vasp utxo callback * Switch to a full 64bit nonce * Use json for parsing in demo vasp (#163) * Update the demo VASP's SDK version to 0.8.0 * Update the demo VASP's SDK version to 0.8.1 * Accept gzip responses, compress request with deflate (#172) Install `ContentEncoding` plugin to handle gzip responses. Compress requests larger than 1K using `Deflater`. Change `addSigningDataIfNeeded()` to return serialised bytes so that we only serialise once. * Regenerate SDK (#173) * Regenerate SDK * no op vls * Update macos environment version (#175) * Uma data visibility (#174) * fix typo (#176) * encode hex (#177) * Bump lightspark-sdk to version 0.14.0 * Load signing key * Revert "Merge release/lightspark-sdk-v0.14.0 into develop" (#181) * Bump lightspark-sdk to version 0.14.0 * update readme (#184) * Update invoice creator (#185) * Bump lightspark-sdk to version 0.15.0 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shreyav <shreya@lightspark.com> Co-authored-by: Jeremy Klein <jklein24@gmail.com> Co-authored-by: Michael Gorven <michael@gorven.net> Co-authored-by: Michael Gorven <mgorven@lightspark.com> Co-authored-by: runner <runner@Mac-1720545346122.local> Co-authored-by: runner <runner@Mac-1720552895732.local> Co-authored-by: runner <runner@Mac-1721165625974.local>
shreyav
added a commit
that referenced
this pull request
Jul 22, 2024
* lnurlp fallback * annotation and tests * fallback sender side * fix serialization * unused import * comments * fixes * Try to fix docs publish job my running on main * [gha] Use environment for doc-publish * Fix sender vasp utxo callback * Switch to a full 64bit nonce * Use json for parsing in demo vasp (#163) * Update the demo VASP's SDK version to 0.8.0 * Update the demo VASP's SDK version to 0.8.1 * Accept gzip responses, compress request with deflate (#172) Install `ContentEncoding` plugin to handle gzip responses. Compress requests larger than 1K using `Deflater`. Change `addSigningDataIfNeeded()` to return serialised bytes so that we only serialise once. * Regenerate SDK (#173) * Regenerate SDK * no op vls * Update macos environment version (#175) * Uma data visibility (#174) * fix typo (#176) * encode hex (#177) * Bump lightspark-sdk to version 0.14.0 * Load signing key * Revert "Merge release/lightspark-sdk-v0.14.0 into develop" (#181) * Bump lightspark-sdk to version 0.14.0 * update readme (#184) * Update invoice creator (#185) * Bump lightspark-sdk to version 0.15.0 * Remove default null on PayUmaInvoice (#189) * Bump lightspark-sdk to version 0.15.1 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shreyav <shreya@lightspark.com> Co-authored-by: Jeremy Klein <jklein24@gmail.com> Co-authored-by: Michael Gorven <michael@gorven.net> Co-authored-by: Michael Gorven <mgorven@lightspark.com> Co-authored-by: runner <runner@Mac-1720545346122.local> Co-authored-by: runner <runner@Mac-1720552895732.local> Co-authored-by: runner <runner@Mac-1721165625974.local> Co-authored-by: runner <runner@Mac-1721683838949.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards LIG-5018