Remove an extra param for outgoing_payment_for_idempotency_key #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyav
approved these changes
Feb 13, 2025
Merge activity
|
jklein24
added a commit
that referenced
this pull request
Jun 21, 2025
* Add the uma-configuration file to the demo VASP * adding sending / receiving vasp methods for demo * change path for requesting invoice * adding basic receiver vasp methods * remove duplicate code for create invoices * change to fetching well known configuration from sending vasp * revert to previous endpoint * adding sender vasp demo endpoints * nits and such * moving parameter to json body * Update SendingVasp.kt * ms -> s * Add explicit timeouts to the Requester * Create SECURITY.md * Regenerating SDKs following introspection of schemas. * Bump ci runners to macos-13. (#214) * Expose idempotency keys for operations which allow them. (#212) * Add the outgoing_payment_for_idempotency_key query. (#213) * Merge release/lightspark-sdk-v0.19.0 into develop (#215) This PR was automatically created by the release branch cut workflow.\nSDK=lightspark-sdk\nVERSION=0.19.0 Co-authored-by: runner <runner@Mac-1739391984425.local> * Remove an extra param for outgoing_payment_for_idempotency_key (#219) This was accidental copy-pasta. * Bump lightspark-sdk to version 0.19.1 * Fix non uma lnurl path (#224) * Bump sdk version, use standard errors in UMA demo vasp (#226) * Added paymentHash and preimageNonce params to createInvoice, createLnurlInvoice, and createUmaInvoice and their respective mutations from all 3 clients. * Added releasePaymentPreimage functions to all 3 kotlin clients * Update Gradle version * Fix misnamed buckets ldev.web-dev -> lsdev.web-dev * Rename to lightspark-dev-web.web-dev * Switch to CENTRAL_PORTAL for maven publishing (#235) * Bump core to version 0.6.1 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Klein <jklein24@gmail.com> Co-authored-by: Matt Davis <mrdavis@lightspark.com> Co-authored-by: Matt Davis <matthappens@gmail.com> Co-authored-by: Joel Weinberger <jww@lightspark.com> Co-authored-by: Jason Wang <jason@lightspark.com> Co-authored-by: Jason Wang <jasoncwangai@gmail.com> Co-authored-by: runner <runner@Mac-1739391984425.local> Co-authored-by: runner <runner@Mac-1739478597077.local> Co-authored-by: Shreya Vissamsetti <shreya@lightspark.com> Co-authored-by: Aaryaman Bhute <aaryaman@lightspark.com> Co-authored-by: Aaryaman Bhute <35084309+AaryamanBhute@users.noreply.github.com> Co-authored-by: Alex Weil <alexweil@lightspark.com> Co-authored-by: Alex Weil <alexjweil@users.noreply.github.com> Co-authored-by: runner <runner@Mac-1750470216285.local>
jklein24
added a commit
that referenced
this pull request
Jun 23, 2025
* Add the uma-configuration file to the demo VASP * adding sending / receiving vasp methods for demo * change path for requesting invoice * adding basic receiver vasp methods * remove duplicate code for create invoices * change to fetching well known configuration from sending vasp * revert to previous endpoint * adding sender vasp demo endpoints * nits and such * moving parameter to json body * Update SendingVasp.kt * ms -> s * Add explicit timeouts to the Requester * Create SECURITY.md * Regenerating SDKs following introspection of schemas. * Bump ci runners to macos-13. (#214) * Expose idempotency keys for operations which allow them. (#212) * Add the outgoing_payment_for_idempotency_key query. (#213) * Merge release/lightspark-sdk-v0.19.0 into develop (#215) This PR was automatically created by the release branch cut workflow.\nSDK=lightspark-sdk\nVERSION=0.19.0 Co-authored-by: runner <runner@Mac-1739391984425.local> * Remove an extra param for outgoing_payment_for_idempotency_key (#219) This was accidental copy-pasta. * Bump lightspark-sdk to version 0.19.1 * Fix non uma lnurl path (#224) * Bump sdk version, use standard errors in UMA demo vasp (#226) * Added paymentHash and preimageNonce params to createInvoice, createLnurlInvoice, and createUmaInvoice and their respective mutations from all 3 clients. * Added releasePaymentPreimage functions to all 3 kotlin clients * Update Gradle version * Fix misnamed buckets ldev.web-dev -> lsdev.web-dev * Rename to lightspark-dev-web.web-dev * Switch to CENTRAL_PORTAL for maven publishing (#235) * Bump core to version 0.6.1 * Bump lightspark-sdk to version 0.20.0 --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremy Klein <jklein24@gmail.com> Co-authored-by: Matt Davis <mrdavis@lightspark.com> Co-authored-by: Matt Davis <matthappens@gmail.com> Co-authored-by: Joel Weinberger <jww@lightspark.com> Co-authored-by: Jason Wang <jason@lightspark.com> Co-authored-by: Jason Wang <jasoncwangai@gmail.com> Co-authored-by: runner <runner@Mac-1739391984425.local> Co-authored-by: runner <runner@Mac-1739478597077.local> Co-authored-by: Shreya Vissamsetti <shreya@lightspark.com> Co-authored-by: Aaryaman Bhute <aaryaman@lightspark.com> Co-authored-by: Aaryaman Bhute <35084309+AaryamanBhute@users.noreply.github.com> Co-authored-by: Alex Weil <alexweil@lightspark.com> Co-authored-by: Alex Weil <alexjweil@users.noreply.github.com> Co-authored-by: runner <runner@Mac-1750470216285.local> Co-authored-by: runner <runner@Mac-1750696645633.local>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidental copy-pasta.