Modernize the python client #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a bunch of non-standard things, both from a LightStep standpoint and from a Python standpoint more generally. Also, add a verbosity option which would have saved trouble debugging some library problems recently.
|
Note that this is not a backwards-compatible change and bumps us to LS tracer 3.x. |
And get the tests closer to reproducing failures. Thrift makes this extremely difficult since it doesn't go down the serialization path unless the actual transport is in a ready state (which it shouldn't be for tests).
|
Looks great @bensigelman . Thanks for making it more consistent with the other client libraries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a bunch of non-standard things, both from a LightStep standpoint and from a Python standpoint more generally. Also, add a verbosity option which would have saved trouble debugging some library problems recently.