[WIP] Liip create bundle #20
Conversation
| $type = $this->typeFactory->getType(get_class($model)); | ||
| $result = $this->restHandler->run($request->request->all(), $type, null, RestService::HTTP_PUT); | ||
|
|
||
| // TODO: what about the filter, if its there? |
There was a problem hiding this comment.
i think this is the most important problem atm. we probably either need to push filtering and validating into the rest controller of createphp or overwrite that controller. ideas and PR welcome.
There was a problem hiding this comment.
i think we should leave out the filter stuff for now ..
There was a problem hiding this comment.
filtering could be configured with the normal createphp type setup and then passed along as config options to the rdfMapper, so transporting this information via createphp wouldn't require any serious code changes. For validation, see my other comment. This needs some sort of support from create.js, since it should normally be handled by the client side, with server validation as fallback only (and of course ideally powered by the same configuration)
|
the new Bundle should be SymfonyCmfCreateBundle |
|
merged into https://github.com/symfony-cmf/CreateBundle |
|
deprecated in favor of SymfonyCmfCreateBundle |
switch to using the createphp library instead of hardcoding rdf into the template and in the model classes. i want to rename this bundle to LiipCreateBundle once we have this functionality.
probably we should first merge #19 and then maybe fix this PR.