Skip to content

CI: upgrade test: bump up the old Lima (v0.10.0→v0.15.1) #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Oct 26, 2023

v0.10.0 (Apr 25, 2022) is too old to test upgradability. Bump up to v0.15.1 (Apr 16, 2023).

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Oct 26, 2023
@AkihiroSuda AkihiroSuda added this to the v1.0 (tentative) milestone Oct 26, 2023
@AkihiroSuda
Copy link
Member Author

Lima v0.15.1 was not compatible with Go 1.21

package github.com/lima-vm/lima/cmd/limactl
	imports github.com/lima-vm/lima/pkg/hostagent
	imports github.com/lima-vm/lima/pkg/cidata
	imports github.com/lima-vm/lima/pkg/limayaml
	imports github.com/lima-vm/lima/pkg/networks
	imports github.com/containers/gvisor-tap-vsock/pkg/virtualnetwork
	imports github.com/containers/gvisor-tap-vsock/pkg/services/dhcp
	imports github.com/containers/gvisor-tap-vsock/pkg/tap
	imports gvisor.dev/gvisor/pkg/tcpip/stack
	imports gvisor.dev/gvisor/pkg/sync/locking
	imports gvisor.dev/gvisor/pkg/gohacks: build constraints exclude all Go files in /Users/runner/go/pkg/mod/gvisor.dev/gvisor@v0.0.0-20221216231429-a78e892a26d2/pkg/gohacks
make: *** [_output/bin/limactl] Error 1

@AkihiroSuda AkihiroSuda changed the title CI: upgrade test: bump up the old Lima (v0.10.0→v0.15.1) CI: upgrade test: bump up the old Lima (v0.10.0→v0.13.0) Oct 26, 2023
@AkihiroSuda
Copy link
Member Author

v0.13 is not compatible with the latest QEMU 😞

@AkihiroSuda AkihiroSuda marked this pull request as draft October 26, 2023 17:26
@AkihiroSuda AkihiroSuda changed the title CI: upgrade test: bump up the old Lima (v0.10.0→v0.13.0) CI: upgrade test: bump up the old Lima (v0.10.0→v0.15.1) Oct 26, 2023
v0.10.0 (Apr 25, 2022) is too old to test upgradability.
Bump up to v0.15.1 (Apr 16, 2023).

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda marked this pull request as ready for review October 26, 2023 18:41
@AkihiroSuda AkihiroSuda requested a review from a team October 27, 2023 11:33
Copy link
Member

@balajiv113 balajiv113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@AkihiroSuda AkihiroSuda merged commit 391133d into lima-vm:master Oct 27, 2023
@AkihiroSuda AkihiroSuda modified the milestones: v1.0, v0.18.1 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants