Skip to content

Automatically unlock disk if it is already locked to the same instance (after restarting macOS) #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

porfirion
Copy link
Contributor

This PR closes #1683

Sometimes disk is not unlocked while shutdown (for example on macOS restart) and existing link prevents restarting vm without additional commands.
Automatically remove existing link when using with the same vm.

@vasileknik76
Copy link
Contributor

vasileknik76 commented Dec 21, 2023

Thanks. Commit doesn't have a DCO signature, so that will need to be fixed before it can be merged: https://github.com/lima-vm/lima/pull/2092/checks?check_run_id=19832769429

@porfirion porfirion force-pushed the unlock-disk branch 3 times, most recently from a16ce8e to 00cfe6d Compare January 12, 2024 16:59
Signed-off-by: Mikhail Vitsen <mikhailvitsen@gmail.com>
@porfirion
Copy link
Contributor Author

Signature added

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v0.20.0 milestone Jan 13, 2024
@AkihiroSuda AkihiroSuda merged commit 2a9dadc into lima-vm:master Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After restarting macOS, additionalDisks of the VM failed to mount (could not attach disk "test", in use by instance "default" )
3 participants