Suppress error if file is already deleted #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arguments were in the wrong order, showing:
INFO[0000] Removing /Users/nsoffer/.lima/c1 under "*.pid *.sock *.tmp"
Fix argument order and clarify the code a little bit to avoid such
failures in the future.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
changed the title
jandubois
reviewed
Sep 25, 2024
jandubois
reviewed
Sep 25, 2024
We have a race (time of check, time of use) when deleting a vm with --force. We first list the file in the instance dir, and then delete matching files. "ssh.sock" is consistently already deleted when we try to remove it, creating unwanted noise in the log. "ssh.sock" is probably removed by other code that may need need to remove it. To make this easy to improve we still log the event in debug level. Fixes: lima-vm#2635 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
|
@jandubois should be ready now, thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a race (time of check, time of use) when deleting a vm with
--force. We first list the file in the instance dir, and then delete
matching files. "ssh.sock" is consistently already deleted when we try
to remove it, creating unwanted noise in the log.
"ssh.sock" is probably removed by other code that may need need to
remove it. To make this easy to improve we still log the event in debug
level.
Also fix a log issue in this same function.
Fixes: #2635