CI: test and fix portfwd issue (`w3m -dump` hangs) #3708

AkihiroSuda · 2025-07-09T08:13:37Z

CI should fail for the first commit, pass for the second commit

AkihiroSuda · 2025-07-09T10:34:44Z

pkg/portfwdserver/server.go

+			return conn, nil
+		}}
+		proxy.HandleConn(rw)
+	}


This workaround is quite dirty, but let's merge this and call it a day to unblock the v1.2 release

Is there an issue for cleaning this up in the future?

Will open an issue after merging this PR

portfwdserver: consolidate bicopy and tcpproxy packages into one #3715

nirs · 2025-07-09T10:52:20Z

hack/test-templates.sh

 			INFO "Testing https://github.com/lima-vm/lima/issues/3685 ([gRPC portfwd] client connection is not closed immediately when server closed the connection)"
 			# Skip the test on Alpine, as systemd-run is missing
+			# Skip the test on WSL2, as port forwarding is half broken https://github.com/lima-vm/lima/pull/3686#issuecomment-3034842616


Do we know if the server close the socket or only do shutdown(SHUT_RD)?

[pid 2675] write(2, "127.0.0.1 - - [10/Jul/2025 13:43"..., 60127.0.0.1 - - [10/Jul/2025 13:43:44] "GET / HTTP/1.0" 200 - ) = 60 [pid 2675] sendto(4, "HTTP/1.0 200 OK\r\nServer: SimpleH"..., 156, 0, NULL, 0) = 156 [pid 2675] sendto(4, "<!DOCTYPE HTML>\n<html lang=\"en\">"..., 1383, 0, NULL, 0) = 1383 [pid 2675] shutdown(4, SHUT_WR) = 0 [pid 2675] close(4) = 0

Test for issue 3685 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

Fix issue 3685 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

jandubois

Thanks, LGTM (at least as a temporary fix)

rpkoller · 2025-07-10T20:31:43Z

just for reference, this PR also fixed #3695, thank you @AkihiroSuda !

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lima-vm/lima](https://github.com/lima-vm/lima) | minor | `v1.1.1` -> `v1.2.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lima-vm/lima (lima-vm/lima)</summary> ### [`v1.2.1`](https://github.com/lima-vm/lima/releases/tag/v1.2.1) [Compare Source](lima-vm/lima@v1.2.0...v1.2.1) #### Changes - Cherry-picks from `master` to `release/1.2` ([#3750](lima-vm/lima#3750)) - portfwd: create separate gRPC streams for each UDP client ([#3724](lima-vm/lima#3724), thanks to [@stek29](https://github.com/stek29)) - qemuimgutil: fix "Failed to get "write" lock" error ([#3742](lima-vm/lima#3742), thanks to [@pavelanni](https://github.com/pavelanni)) - Embed templates edited from the user interface ([#3745](lima-vm/lima#3745), thanks to [@afbjorklund](https://github.com/afbjorklund)) #### Usage ```console $ limactl create $ limactl start ... INFO[0029] READY. Run `lima` to open the shell. $ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/16405168554 The sha256sum of the SHA256SUMS file itself is `fda636e062d8f75a689071b308a94dc902111620f7122746fc0d172959d7d26a` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) ### [`v1.2.0`](https://github.com/lima-vm/lima/releases/tag/v1.2.0) [Compare Source](lima-vm/lima@v1.1.1...v1.2.0) #### Changes - `limactl` CLI: - Add `limactl network (list|create|delete)` commands ([#3677](lima-vm/lima#3677)) - Add `limactl clone OLDINST NEWINST` command. Not to be confused with `limactl copy`, which copies files. ([#3673](lima-vm/lima#3673)) - Add `limactl edit --mount-none` flag ([#3647](lima-vm/lima#3647)) - Port forwarding: - Improve stability ([#3684](lima-vm/lima#3684). [#3708](lima-vm/lima#3708), thanks to [@balajiv113](https://github.com/balajiv113)) - De-deprecate `LIMA_SSH_PORT_FORWARDER` that was once deprecated in v1.1 ([#3709](lima-vm/lima#3709)) - nerdctl: - Update from v2.1.2 to [v2.1.3](https://github.com/containerd/nerdctl/releases/tag/v2.1.3) ([#3701](lima-vm/lima#3701)) - Templates: - `default`: update from Ubuntu 24.10 to 25.04 ([#3643](lima-vm/lima#3643)) - `fedora`: update from Fedora 41 to 42 ([#3643](lima-vm/lima#3643)) - `almalinux-10`: new template ([#3602](lima-vm/lima#3602), thanks to [@refi64](https://github.com/refi64)) - `rocky-10`: new template ([#3642](lima-vm/lima#3642)) - `experimental/debian-testing`: new template ([#3645](lima-vm/lima#3645)) - `experimental/ubuntu-next`: new template ([#3645](lima-vm/lima#3645)) - Makefile: - Kconfig: deprecate ([#3706](lima-vm/lima#3706)) > \[!NOTE] > On Intel Mac, macOS 15.5 or later is needed to boot the default Ubuntu 25.04 template. > > Workarounds for macOS <= 15.4 : > > - Option 1: Use QEMU > > ``` > limactl create --vm-type=qemu > ``` > > - Option2: Use Ubuntu 24.04 template > > ``` > limactl create --name=default template://ubuntu-24.04 > ``` Full changes: https://github.com/lima-vm/lima/milestone/61?closed=1 Thanks to [@AkinoKaede](https://github.com/AkinoKaede) [@Horiodino](https://github.com/Horiodino) [@afbjorklund](https://github.com/afbjorklund) [@alexandear](https://github.com/alexandear) [@arixmkii](https://github.com/arixmkii) [@balajiv113](https://github.com/balajiv113) [@fruzitent](https://github.com/fruzitent) [@jandubois](https://github.com/jandubois) [@kachick](https://github.com/kachick) [@mazzz1y](https://github.com/mazzz1y) [@nirs](https://github.com/nirs) [@refi64](https://github.com/refi64) [@songponssw](https://github.com/songponssw) [@thomasjm](https://github.com/thomasjm) [@unsuman](https://github.com/unsuman) #### Usage ```console $ limactl create $ limactl start ... INFO[0029] READY. Run `lima` to open the shell. $ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/16187325385 The sha256sum of the SHA256SUMS file itself is `f4d57cdd637022ead291af680c0c88a8d07fd35fd6a779b7c6348e2c9a2ec2cc` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

AkihiroSuda added this to the v1.2.0 milestone Jul 9, 2025

AkihiroSuda added area/test Tests and CI area/portfwd labels Jul 9, 2025

AkihiroSuda mentioned this pull request Jul 9, 2025

CI: portfwd tests should cover keepalive and other connectivity issues #3687

Open

1 task

AkihiroSuda force-pushed the fix-3685-2 branch 3 times, most recently from 8f7bbfd to 0678d67 Compare July 9, 2025 08:45

AkihiroSuda changed the title ~~CI: test portfwd issue (w3m -dump hangs)~~ CI: test and fix portfwd issue (w3m -dump hangs) Jul 9, 2025

AkihiroSuda marked this pull request as ready for review July 9, 2025 10:33

AkihiroSuda commented Jul 9, 2025

View reviewed changes

AkihiroSuda mentioned this pull request Jul 9, 2025

Import gvisor-tap-vsock/pkg/tcpproxy into pkg/tcpproxy #3686

Closed

nirs approved these changes Jul 9, 2025

View reviewed changes

alexandear approved these changes Jul 9, 2025

View reviewed changes

AkihiroSuda added 2 commits July 10, 2025 13:28

CI: test portfwd issue (w3m -dump hangs)

c41880f

Test for issue 3685 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

portfwdserver: use tcpproxy to fix w3m -dump issue

6ca9e7f

Fix issue 3685 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

AkihiroSuda force-pushed the fix-3685-2 branch from 99944fc to 6ca9e7f Compare July 10, 2025 04:28

AkihiroSuda requested a review from jandubois July 10, 2025 04:47

jandubois approved these changes Jul 10, 2025

View reviewed changes

jandubois merged commit 83cbc02 into lima-vm:master Jul 10, 2025
36 checks passed

rpkoller mentioned this pull request Jul 10, 2025

some http connections load indefinitely on localhost, starting with lima 1.1.0 #3695

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CI: test and fix portfwd issue (`w3m -dump` hangs) #3708

CI: test and fix portfwd issue (`w3m -dump` hangs) #3708

Uh oh!

AkihiroSuda commented Jul 9, 2025 •

edited

Loading

Uh oh!

AkihiroSuda Jul 9, 2025

Uh oh!

jandubois Jul 9, 2025

Uh oh!

AkihiroSuda Jul 10, 2025

Uh oh!

AkihiroSuda Jul 10, 2025

Uh oh!

nirs Jul 9, 2025

Uh oh!

AkihiroSuda Jul 10, 2025

Uh oh!

jandubois left a comment

Uh oh!

Uh oh!

rpkoller commented Jul 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

CI: test and fix portfwd issue (w3m -dump hangs) #3708

CI: test and fix portfwd issue (w3m -dump hangs) #3708

Uh oh!

Conversation

AkihiroSuda commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

jandubois Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

nirs Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

jandubois left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rpkoller commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CI: test and fix portfwd issue (`w3m -dump` hangs) #3708

CI: test and fix portfwd issue (`w3m -dump` hangs) #3708

AkihiroSuda commented Jul 9, 2025 •

edited

Loading

rpkoller commented Jul 10, 2025 •

edited

Loading