Skip to content

Use errors.As() instead of type assertions #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Use errors.As() instead of type assertions #3938

merged 1 commit into from
Sep 1, 2025
+10 −12

Conversation

jandubois
Copy link
Member

It is more idiomatic because it also works for wrapped errors.

@jandubois
Use errors.As() instead of type assertions
d871572 
It is more idiomatic because it also works for wrapped errors.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Sep 1, 2025
@AkihiroSuda AkihiroSuda added the kind/refactoring Refactoring label Sep 1, 2025
AkihiroSuda
AkihiroSuda approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit a89ce4c into lima-vm:master Sep 1, 2025
36 checks passed
@jandubois jandubois deleted the error-as branch September 1, 2025 08:09
@jandubois jandubois mentioned this pull request Oct 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
kind/refactoring Refactoring
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jandubois @AkihiroSuda