Skip to content

print an error that wraps ExitError #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
+7 −3
Merged

print an error that wraps ExitError #4168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/osutil/exit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,22 @@
package osutil

import (
"errors"
"os"
"os/exec"
)

// HandleExitError calls os.Exit immediately without printing an error, only if the error is an *exec.ExitError (non-nil).
//
// The function does not call os.Exit if the error is of any other type, even if it wraps an *exec.ExitError,
// so that the caller can print the error message.
func HandleExitError(err error) {
if err == nil {
return
}

var exitErr *exec.ExitError
if errors.As(err, &exitErr) {
// Do not use errors.As, because we want to match only *exec.ExitError, not wrapped ones.
// https://github.com/lima-vm/lima/pull/4168
if exitErr, ok := err.(*exec.ExitError); ok {
os.Exit(exitErr.ExitCode()) //nolint:revive // it's intentional to call os.Exit in this function
return
}
Expand Down