Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loade plugin keymaps and settings in correct order #468

Merged
merged 5 commits into from
Dec 8, 2014
Merged

Loade plugin keymaps and settings in correct order #468

merged 5 commits into from
Dec 8, 2014

Conversation

zoli
Copy link
Member

@zoli zoli commented Dec 6, 2014

Now Vintageous plugin works properly on front ends closes #467.
BTW why we're using Vintageous fork?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling b7bc206 on zidoms:iss467 into 431e005 on limetext:master.

@FichteFoll
Copy link

Probably because the current version uses API calls that lime does or did not support. Or maybe just so that there was something to work with that wouldn't change constantly.

zoli added a commit that referenced this pull request Dec 8, 2014
Loade plugin keymaps and settings in correct order
@zoli zoli merged commit a0f16f7 into limetext:master Dec 8, 2014
@zoli zoli deleted the iss467 branch December 8, 2014 18:48
@quarnster
Copy link
Member

BTW why we're using Vintageous fork?

Because we were referencing the lime2 branch, but it appears that the move to from 3rdparty -> packages incorrectly made it reference master. I don't see how that even can work and looking at the travis build it looks to me like the Vintageous tests aren't actually running at all which might explain why they don't explicitly fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loade plugin keymaps and settings in correct order
4 participants