Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃専 Added link preview service #2204

Merged
merged 6 commits into from Jun 2, 2022
Merged

馃専 Added link preview service #2204

merged 6 commits into from Jun 2, 2022

Conversation

rezk2ll
Copy link
Member

@rezk2ll rezk2ll commented May 31, 2022 •
edited

Description

  • adds preview service for links
  • detects links in message and fire the link preview service
  • updates the message links field with yielded results

Related Issue

#2139

Motivation and Context

  • links in messages do not have previews

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

linkpreview2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added the Signed-off-by statement at the end of my commit message.

@RomaricMourgues RomaricMourgues changed the title 馃専 added link preview service 馃専 Added link preview service May 31, 2022
@rezk2ll rezk2ll force-pushed the #2139 branch 3 times, most recently from e0c3296 to cf7e844 Compare June 1, 2022 09:41
@rezk2ll rezk2ll marked this pull request as ready for review June 1, 2022 09:42
@rezk2ll rezk2ll linked an issue Jun 1, 2022 that may be closed by this pull request
LinksPreview::Link thumbnail on web (and improve on mobile) #2139
Closed
@RomaricMourgues
Copy link
Contributor

Great, should I wait more to get the thumbnail size ?

@rezk2ll
Copy link
Member Author

rezk2ll commented Jun 2, 2022 •
edited

Great, should I wait more to get the thumbnail size ?

it's already done here

@RomaricMourgues RomaricMourgues merged commit 8f18380 into linagora:develop Jun 2, 2022
@RomaricMourgues RomaricMourgues added the qa:ready When a PR is ready to go to QA label Jun 2, 2022
RomaricMourgues pushed a commit that referenced this pull request Jun 2, 2022
@rezk2ll
馃専 Added link preview service (#2204)
d9782bb 
* 馃専 added link preview service

* unit tests

* moved links preview callback handler to message service

* added publish message in realtime helper

* publish message in realtime after preview generation

* publish message only to channels
@github-actions github-actions bot added staging:qa and removed qa:ready When a PR is ready to go to QA labels Jun 2, 2022
@rezk2ll rezk2ll mentioned this pull request Jun 2, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomaricMourgues RomaricMourgues RomaricMourgues approved these changes

@romanesko romanesko Awaiting requested review from romanesko

Assignees
No one assigned
Labels
staging:main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LinksPreview::Link thumbnail on web (and improve on mobile)
3 participants
@rezk2ll @RomaricMourgues @shepilov