🌟 Implement media filter and both download and upload origin #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomaricMourgues
added a commit
that referenced
this pull request
Jun 1, 2022
* Implement media filter and both download and upload origin * Add user in the file object * Fix recent backend endpoints * Fixing tests * Fix tests
github-actions
bot
added
staging:qa
and removed
qa:ready
RomaricMourgues
added
canary:ready
RomaricMourgues
added a commit
that referenced
this pull request
Jun 1, 2022
* Implement media filter and both download and upload origin * Add user in the file object * Fix recent backend endpoints * Fixing tests * Fix tests
github-actions
bot
added
staging:canary
and removed
canary:ready
romanesko
reviewed
Jun 1, 2022
| @@ -131,17 +136,15 @@ export class ViewsController { | |||
|
|
|||
| const userFiles = await gr.services.files.listUserMarkedFiles( | |||
| request.currentUser.id, | |||
| request.query.type, | |||
| request.query.type || "both", | |||
There was a problem hiding this comment.
request.query.type can't be undefined (to become "both") cause it has strict check on line 133
There was a problem hiding this comment.
Oups, my mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2203
#2207
Documentation updated at https://www.notion.so/linagora/Rest-APIs-232eb8e51c3743ccbb7aa3534a5a7db9