Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌟 Add version detail in the Help tab #2263

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

oubchid
Copy link
Contributor

@oubchid oubchid commented Jun 9, 2022

Description

  • Add version detail in the Help tab

Related Issue

#2055

Motivation and Context

Quick view to see the current Version displayed directly in help menu.

How Has This Been Tested?

  • Add a flag to be able to test in local

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added the Signed-off-by statement at the end of my commit message.

@RomaricMourgues
Copy link
Contributor

Hello ! Please follow this notation for new PRs name: https://www.notion.so/linagora/Release-workflow-ca674f1c66c14d45bc747e1fcdb924e3#2238e83cd5404449ac26e70c4225901a
In your case it would be a 🌟 .
I did not mention it, but you must not merge the PRs here, I will do it for the first months :)

@RomaricMourgues
Copy link
Contributor

Oh I see you did it in the commit name, great ! But as we will do squash and merge, it must also be in the PR name :)

@oubchid oubchid changed the title Add version detail in the Help tab 🔖 Add version detail in the Help tab Jun 10, 2022
@oubchid oubchid changed the title 🔖 Add version detail in the Help tab 🌟 Add version detail in the Help tab Jun 10, 2022
@RomaricMourgues RomaricMourgues merged commit 90af0a9 into linagora:develop Jun 10, 2022
@RomaricMourgues RomaricMourgues added the qa:ready When a PR is ready to go to QA label Jun 10, 2022
@github-actions github-actions bot added staging:qa and removed qa:ready When a PR is ready to go to QA staging:develop labels Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants