📁 Canary drive fix 1 #2774

RomaricMourgues · 2023-03-09T10:51:51Z

[Major] Plugins are broken or server has issues ?
[Medium] Going to applications list crashes the app
[Minor] Remove the option to create a "write" public shared link
Check full access vs write for deletion
Moved folder not displayed as moved
Should not propose to change its own access to a document
Change how menus work to take multi-selection into account from right "..."
Limit folders names and add max-width wit ellipsis
Redirect user to root when access to current folder is changed
Cancel upload crash Twake
Fix version modal not being updated
Fix new versions not being searchable
Fix new versions no thumbnails

github-actions · 2023-03-09T12:06:58Z

Lines	Statements	Branches	Functions
	59.26% (5294/8933)	50.46% (2241/4441)	58.99% (1303/2209)

Coverage Report (10%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	10.29	7.52	8.95	10.47
core/config	0	0	0	0
index.ts	0	0	0	0
core/crypto	83.82	72.73	66.67	83.82
index.ts	75	71.43	33.33	75	37–49
legacy.ts	84.62	62.5	50	84.62	14, 41
v1.ts	85	77.78	100	85	26, 48, 62
v2.ts	86.96	77.78	100	86.96	26, 48, 65
core/platform/framework	46.88	31.58	50	46.88
configuration.ts	87.5	42.86	100	87.5	27
event-bus.ts	21.43	0	25	21.43	19–43
factory.ts	16.67	0	0	16.67	20–28
index.ts	0	0	0	0
logger.ts	100	50	100	100	10–21
core/platform/framework/api	10.32	2.78	11.11	10.57
application-configuration.ts	0	0	0	0
class.ts	0	0	0	0
component.ts	0	0	0	0	10–65
constants.ts	100	100	100	100
container.ts	0	0	0	0	17–71
context.ts	0	0	0	0
crud-service.ts	39.13	25	27.78	42.86	90–94, 102–167
index.ts	0	0	0	0
lifecycle.ts	0	0	0	0
service-configuration.ts	0	0	0	0
service-definition.ts	0	0	0	0
service-interface.ts	0	0	0	0
service-options.ts	0	0	0	0
service-provider.ts	0	0	0	0
service-state.ts	0	0	0	0
service.ts	1.75	0	0	1.75	24–131
core/platform/framework/decorators	28.57	0	33.33	28.57
consumes.ts	100	0	100	100	3
index.ts	0	0	0	0
prefix.ts	0	0	0	0	5–6
service-name.ts	0	0	0	0	5–7
core/platform/framework/decorators/realtime	83.02	65.79	85	84.31
created.ts	100	83.33	100	100	31
deleted.ts	100	83.33	100	100	25
index.ts	83.33	61.11	75	90	66
saved.ts	30	0	50	30	18–38
updated.ts	100	100	100	100
core/platform/framework/utils	0	0	0	0
component-utils.ts	0	0	0	0	15–107
loader.ts	0	0	0	0	9–43
core/platform/services/database/services/orm	62.5	38.46	66.67	64.52
utils.ts	62.5	38.46	66.67	64.52	18–31, 62–63, 89, 103
core/platform/services/database/services/orm/connectors/cassandra	42.37	33.33	80	40.54
query-builder.ts	88.37	70.37	84.62	89.19	27, 67–71, 127
typeTransforms.ts	16	11.83	50	16.22	40–43, 48, 51, 57, 63–104, 112–173
core/platform/services/database/services/orm/decorators	100	80	100	100
column.ts	100	100	100	100
entity.ts	100	50	100	100	23
index.ts	0	0	0	0
core/platform/services/knowledge-graph	0	0	0	0
api-client.ts	0	0	0	0	15–178
index.ts	0	0	0	0	22–165
types.ts	0	0	0	0
core/platform/services/message-queue	83.33	71.88	88.89	87.5
api.ts	83.33	71.88	88.89	87.5	165, 190, 201, 249–253
core/platform/services/realtime	66.67	50	66.67	66.67
bus.ts	75	100	66.67	75	14
types.ts	50	50	66.67	50	21
services	5	0	0	5
global-resolver.ts	5	0	0	5	134–225
services/applications	0	100	0	0
realtime.ts	0	100	0	0	4–12
services/applications/entities	12.5	100	0	12.5
application.search.ts	0	100	0	0	6
application.ts	10	100	0	10	14–101
company-application.ts	20	100	0	20	12–27
services/applications/services	0	0	0	0
applications.ts	0	0	0	0	29–141
company-applications.ts	0	0	0	0	31–182
hooks.ts	0	0	0	0	21–92
internal-event-to-hooks.ts	0	0	0	0	9–52
services/channels	100	100	100	100
types.ts	0	0	0	0
utils.ts	100	100	100	100
services/channels/entities	1.45	0	0	1.45
channel-activity.ts	0	0	0	0	13–57
channel-counters.ts	100	100	100	100
channel-member-read-cursors.ts	0	100	0	0	12–26
channel-member.ts	0	0	0	0	19–137
channel-pending-emails.ts	0	100	0	0	13–45
channel.search.ts	0	100	0	0	6
channel.ts	0	0	0	0	17–105
default-channel.ts	0	100	0	0	12–33
direct-channel.ts	0	0	0	0	18–46
index.ts	0	0	0	0
member.ts	0	100	0	0	4
tab.ts	0	0	0	0	11–48
services/channels/services	0	0	0	0
tab.ts	0	0	0	0	24–135
services/channels/services/channel	0.34	0	0	0.35
realtime.ts	0	0	0	0	7–49
service.ts	0.36	0	0	0.37	66–983
types.ts	0	0	0	0	33–65
services/channels/services/channel/default	2.33	0	0	2.35
listener.ts	3.57	0	0	3.57	13–110
service.ts	1.72	0	0	1.75	36–256
services/channels/services/channel/pending-emails	3.57	0	0	3.7
service.ts	3.57	0	0	3.7	33–178
services/channels/services/member	1.28	0	0	1.31
realtime.ts	0	0	0	0	7–40
service.ts	1.32	0	0	1.36	90–910
services/channels/services/pubsub	9.33	0	0	9.33
index.ts	0	100	0	0	11–22
new-channel-activity.ts	7.69	0	0	7.69	19–85
new-direct-channel-message.ts	4.17	0	0	4.17	14–87
new-pending-emails-in-workspace-join-channels.ts	20	0	0	20	19–51
new-user-in-workspace-join-default-channels.ts	16.67	0	0	16.67	18–52
new-workspace.ts	11.11	0	0	11.11	11–51
services/console	5.26	0	0	5.26
client-factory.ts	16.67	0	0	16.67	9–16
service.ts	0	0	0	0	23–76
services/console/clients	0	0	0	0
internal.ts	0	0	0	0	34–105
remote.ts	0	0	0	0	36–496
services/console/processing	1	0	0	1.02
merge.ts	1	0	0	1.02	57–416
services/documents	8.81	0	0	9.57
const.ts	100	100	100	100
utils.ts	8.41	0	0	9.13	40–84, 98–117, 126–128, 142–152, 162–167, 177–182, 198–231, 247–263, 281–301, 322–327, 346–441, 459–515, 537–570, 581–598, 609–623, 636–652, 667–676, 701–729, 749–795
services/documents/entities	9.09	0	0	9.09
drive-file.search.ts	0	0	0	0	5
drive-file.ts	7.14	100	0	7.14	16–70
drive-twake-tab.ts	16.67	100	0	16.67	11–27
file-version.ts	8.33	100	0	8.33	11–54
services/documents/services	0	0	0	0
index.ts	0	0	0	0	55–831
services/documents/services/engine	0	0	0	0
extract-keywords.ts	0	0	0	0	13–77
index.ts	0	100	0	0	9–16
save-keywords.ts	0	0	0	0	13–62
services/files	28.57	0	0	33.33
utils.ts	28.57	0	0	33.33	5–9, 20
services/files/entities	0	0	0	0
file.ts	0	0	0	0	10–51
services/files/services	0	0	0	0
index.ts	0	0	0	0	23–306
preview.ts	0	0	0	0	18–65
services/files/web	28.57	100	0	28.57
routes.ts	28.57	100	0	28.57	8–50, 54, 58
services/files/web/controllers	0	0	0	0
files.ts	0	0	0	0	17–104
index.ts	0	0	0	0
services/messages/entities	11.88	0	0	11.88
message-channel-marked-refs.ts	10	100	0	10	11–50
message-channel-refs-reversed.ts	14.29	100	0	14.29	11–38
message-channel-refs.ts	14.29	100	0	14.29	11–38
message-file-refs.ts	8.33	100	0	8.33	11–58
message-files.search.ts	20	0	0	20	6–28
message-files.ts	25	100	0	25	13–22
message-user-inbox-refs-reversed.ts	16.67	100	0	16.67	11–34
message-user-inbox-refs.ts	12.5	100	0	12.5	11–42
message-user-marked_refs.ts	10	100	0	10	11–50
messages.search.ts	0	0	0	0	8–38
messages.ts	10	100	0	10	17–132
threads.ts	12.5	100	0	12.5	11–50
user-message-bookmarks.ts	14.29	100	0	14.29	11–36
services/messages/services	0.76	0	0	0.79
messages-files.ts	0	0	0	0	18–168
messages-operations.ts	0	0	0	0	25–299
messages.ts	0.32	0	0	0.33	75–1056, 1064
threads.ts	0	0	0	0	30–302
user-bookmarks.ts	0	0	0	0	27–100
utils.ts	12.12	0	0	13.33	21–23, 34–58, 69–72, 85–92
views.ts	0	0	0	0	44–454
services/messages/services/engine	0	0	0	0
index.ts	0	0	0	0	35–110
services/messages/services/engine/processors/channel-marked	0	0	0	0
index.ts	0	0	0	0	15–41
services/messages/services/engine/processors/channel-view	0	0	0	0
index.ts	0	0	0	0	19–140
services/messages/services/engine/processors/files	0	0	0	0
index.ts	0	0	0	0	19–140
services/messages/services/engine/processors/links	0	0	0	0
index.ts	0	0	0	0	17–83
services/messages/services/engine/processors/message-to-hooks	0	0	0	0
index.ts	0	0	0	0	13–101
services/messages/services/engine/processors/message-to-notifications	0	0	0	0
index.ts	0	0	0	0	16–173
services/messages/services/engine/processors/system-activity-message	0	0	0	0
index.ts	0	0	0	0	11–49
services/messages/services/engine/processors/user-inbox	0	0	0	0
index.ts	0	0	0	0	22–89
services/messages/services/engine/processors/user-marked	0	100	0	0
index.ts	0	100	0	0	9
services/messages/web	50	100	0	50
realtime.ts	50	100	0	50	4, 8, 12
services/messages/web/controllers	0.5	0	0	0.51
index.ts	16.67	0	0	20	13–17
messages.ts	0	0	0	0	54–522
threads.ts	0	0	0	0	42–90
user-bookmarks.ts	0	0	0	0	38–122
views.ts	0	0	0	0	37–309
services/messages/web/controllers/views	1.96	0	0	2
recent-files.ts	0	0	0	0	19–28
search-files.ts	2.08	0	0	2.13	44–63, 77–210
services/notifications/entities	31.03	100	4.76	31.03
channel-member-notification-preferences.ts	37.5	100	0	37.5	15–33, 49
channel-thread-users.ts	33.33	100	20	33.33	15–38
index.ts	0	0	0	0
user-notification-badges.ts	27.27	100	0	27.27	20–63, 77
user-notification-digest.ts	25	100	0	25	18–42
services/notifications/notifiers	88.89	100	100	88.89
index.ts	0	0	0	0
mobile-push.ts	88.89	100	100	88.89	29
services/notifications/services	0.92	0	1.64	0.98
bages.ts	0	0	0	0	36–300
channel-preferences.ts	2.86	0	0	3.03	24–155
channel-thread-users.ts	0	0	0	0	22–66
digest.ts	0	0	0	0	19–161
mobile-push.ts	0	0	0	0	13–57
preferences.ts	0	0	0	0	26–141
realtime.ts	50	100	50	50	4
services/notifications/services/engine	0	100	0	0
index.ts	0	100	0	0	18–34
services/notifications/services/engine/processors	40.1	32.9	50.94	39.5
channel-member-created.ts	0	0	0	0	16–73
channel-member-deleted.ts	0	0	0	0	15–95
channel-member-updated.ts	0	0	0	0	14–49
mark-channel-as-read.ts	0	0	0	0	11–64
mark-channel-as-unread.ts	0	0	0	0	11–62
mobile-push-notifications.ts	0	0	0	0	16–46
new-channel-message.ts	96.15	75.76	94.44	96	32, 94
push-to-users.ts	68.89	54.17	71.43	68.89	39, 76–77, 131, 192–193, 206–209, 213–216
reaction-notification.ts	0	0	0	0	20–128
services/online	100	100	100	100
constants.ts	100	100	100	100
services/online/entities	20	100	0	20
user-online.ts	20	100	0	20	12–31
services/online/pubsub	0	0	0	0
index.ts	0	0	0	0	10–25
processor.ts	0	0	0	0	14–50
services/online/service	0	0	0	0
index.ts	0	0	0	0	19–172
services/previews	60	75	50	65.22
utils.ts	60	75	50	65.22	10–13, 26, 31, 46, 65
services/previews/services/files/engine	1.92	0	0	2
clear.ts	0	0	0	0	12–46
index.ts	0	100	0	0	11–13
service.ts	2.7	0	0	2.78	19–116
services/previews/services/files/processing	37.17	34.62	64.71	37.5
image.ts	0	0	0	0	14–53
office.ts	10	0	0	10	12–27
pdf.ts	0	0	0	0	11–42
service.ts	0	0	0	0	21–69
video.ts	97.62	90	100	97.62	127
services/previews/services/links/engine	0	0	0	0
index.ts	0	100	0	0	7–9
service.ts	0	0	0	0	13–78
services/previews/services/links/processing	91.67	66.67	100	91.67
image.ts	100	50	100	100	14
link.ts	91.3	66.67	100	91.3	46, 56
service.ts	85.71	70	100	85.71	33, 44
services/statistics	100	100	100	100
types.ts	100	100	100	100
services/statistics/entities	50	100	0	50
statistics.ts	50	100	0	50	29
services/statistics/pubsub	11.11	0	0	11.11
messages.ts	11.11	0	0	11.11	9–30
services/statistics/service	0	0	0	0
index.ts	0	0	0	0	16–67
services/tags/entities	28.57	100	0	28.57
index.ts	0	0	0	0
tags.ts	28.57	100	0	28.57	18–41, 49
services/tags/services	0	100	0	0
tags.ts	0	100	0	0	21–55
services/user	0	100	0	0
realtime.ts	0	100	0	0	9–44
services/user/entities	22.22	0	0	22.22
company.ts	50	100	0	50	61
company_user.ts	25	100	0	25	26–62
device.ts	50	100	0	50	31
external_company.ts	50	100	0	50	26
external_user.ts	50	100	0	50	24
user.search.ts	0	0	0	0	6–18
user.ts	9.09	0	0	9.09	31–146
services/user/services	0	0	0	0
companies.ts	0	0	0	0	49–351
services/user/services/external_links	0	0	0	0
index.ts	0	0	0	0	18–64
services/user/services/users	0	0	0	0
service.ts	0	0	0	0	51–392
services/user/web	0	0	0	0
types.ts	0	0	0	0
services/workspaces	0	100	0	0
realtime.ts	0	100	0	0	6–29
services/workspaces/entities	37.5	0	0	40
workspace.ts	50	100	0	50	49
workspace_counters.ts	100	100	100	100
workspace_invite_domain.ts	50	100	0	50	29
workspace_invite_tokens.ts	50	100	0	50	35
workspace_pending_users.ts	50	100	0	50	36
workspace_user.ts	14.29	0	0	16.67	25–48
services/workspaces/services	0	0	0	0
workspace.ts	0	0	0	0	82–862
utils	10.11	0	3.92	10.29
coalesce.ts	0	0	0	0	3–6
company.ts	0	0	0	0	5–46
counters.ts	10	0	0	11.11	14–22
files.ts	17.5	0	0	19.44	14–16, 25–26, 38–55, 65, 75–80, 91–103
handleError.ts	0	0	0	0	6–10
messages.ts	0	0	0	0	10–110
mime.ts	100	100	100	100
password-encoder.ts	0	0	0	0	7–80
pick.ts	100	100	100	100
types.ts	100	100	100	100
users.ts	0	0	0	0	15–94
uuid-reducer.ts	25	0	0	33.33	2–4, 11–13
workspace.ts	0	0	0	0	7–46

* Fix plugins, public write, apps crash * Asynchronous menus for drive * Load page before to change it * Remove id restriction and allow delete only to manage * Several fixes around versions

RomaricMourgues added 3 commits March 9, 2023 10:12

Fix plugins, public write, apps crash

c0c77f8

Asynchronous menus for drive

c11a906

Load page before to change it

0dc497e

RomaricMourgues changed the title ~~Canary drive fix 1~~ 📁 Canary drive fix 1 Mar 9, 2023

This was referenced Mar 9, 2023

📁 TDrive - Improve access management popup #2773

Open

📁 TDrive canary bugs #2772

Open

Remove id restriction and allow delete only to manage

3a650e1

Several fixes around versions

af2fc06

RomaricMourgues merged commit ebd08c5 into linagora:develop Mar 9, 2023

github-actions bot added the staging:develop label Mar 9, 2023

RomaricMourgues added the qa:ready When a PR is ready to go to QA label Mar 9, 2023

github-actions bot added the staging:qa label Mar 9, 2023

github-actions bot removed qa:ready When a PR is ready to go to QA staging:develop labels Mar 9, 2023

RomaricMourgues added the canary:ready Any PR with this label will be cherry picked in canary environment label Mar 9, 2023

github-actions bot added the staging:canary label Mar 9, 2023

github-actions bot removed canary:ready Any PR with this label will be cherry picked in canary environment staging:qa labels Mar 9, 2023

RomaricMourgues added staging:main and removed staging:canary labels Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📁 Canary drive fix 1 #2774

📁 Canary drive fix 1 #2774

RomaricMourgues commented Mar 9, 2023 •

edited

Loading

github-actions bot commented Mar 9, 2023 •

edited

Loading

📁 Canary drive fix 1 #2774

📁 Canary drive fix 1 #2774

Conversation

RomaricMourgues commented Mar 9, 2023 • edited Loading

github-actions bot commented Mar 9, 2023 • edited Loading

RomaricMourgues commented Mar 9, 2023 •

edited

Loading

github-actions bot commented Mar 9, 2023 •

edited

Loading