Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme, add travis, pep fixes, python3 compatibility #15

Closed
wants to merge 45 commits into from

Conversation

brennv
Copy link
Contributor

@brennv brennv commented Mar 26, 2017

No description provided.

@bdewilde
Copy link

Hi @brennv , I'd love to see this PR get merged! Is there anything I can do to push the process forward?

@brennv
Copy link
Contributor Author

brennv commented Aug 17, 2017

I think we need to get LinkedIn's attention. I'm guessing this was an intern project that no longer has a clear maintainer.

@bdewilde
Copy link

Aha. Hey @RiteshMaheshwari, are you still developing/maintaining this project? If not, do you know who might be?

@bdewilde
Copy link

Well, I could just start tagging people in the linkedin github org... unless you have a better idea, @brennv ? :)

@brennv
Copy link
Contributor Author

brennv commented Aug 24, 2017

That sounds like a good plan. What do you think @jodzga ?

@brennv brennv changed the title Update readme Update readme, add travis, pep fixes, python3 compatibility Aug 24, 2017
@jodzga
Copy link

jodzga commented Aug 24, 2017

Not it, but I'll try to find the right person :-)

@brennv
Copy link
Contributor Author

brennv commented Aug 24, 2017

Thanks @jodzga, I'm happy to simplify things by splitting out the issues further if need be. As is, this includes #11 and #13.

I'm also happy to help maintain the repo if new owners are needed.

@RiteshMaheshwari
Copy link
Contributor

@brennv We haven't updated the codebase on luminol in a while as another internal project has replaced it. I am happy to merge simple pull requests though. Can you please split them into logical separate requests? Thanks!

@brennv
Copy link
Contributor Author

brennv commented Aug 26, 2017

Thanks @RiteshMaheshwari, much appreciated. I think adding travis and getting tests passing would good start. That way we can watch follow-on PRs pass or fail.

I think the logical order for the current proposed changes would be:

  • add travis Add travis #11
  • fix tests fix tests #20
  • add test runner with linting and coverage
  • pep8 fixes
  • add Python3 support
  • update readme
  • bump pypi release

The first two are ready to go now. Depending on your thoughts I can start splitting out the rest.

@brennv brennv mentioned this pull request Aug 27, 2017
8 tasks
@brennv
Copy link
Contributor Author

brennv commented Aug 27, 2017

Moving the conversation to #22. Closing this PR in favor of #11 #20 #21 #13 etc

@brennv brennv closed this Aug 27, 2017
@brennv brennv mentioned this pull request Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants