Return RetriableRequestException for Netty Max Active Stream error #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHorth
reviewed
May 23, 2024
r2-core/src/main/java/com/linkedin/r2/transport/http/common/HttpBridge.java
Outdated
Show resolved
Hide resolved
| { | ||
| StreamException streamException = (StreamException) responseError; | ||
| response = TransportResponseImpl.error( | ||
| new RetriableRequestException("Failed to get response from server for URI " + uri, streamException), |
There was a problem hiding this comment.
Can we avoid duplicating the exception message?
RemoteInvocationException wrapException(String message, Throwable exception) {
if (shouldReturnRetriableRequestException(exception)) {
return new RetriableRequestException(message, exception);
} else {
return new RemoteInvocationException(message, exception);
}
}
r2-core/src/main/java/com/linkedin/r2/transport/http/common/HttpBridge.java
Outdated
Show resolved
Hide resolved
junchuanwang
temporarily deployed
to
jfrog-publish
GitHub Actions
Inactive
TylerHorth
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds logic in
HttpBridgeto returnRetriableRequestExceptionrather thanRemoteInvocationExceptionwhen StreamException from Netty is returned with cause ofMaximum active streams violated for this endpoint. This allows the downstream client -RetryClientto retry the request with different hosts when stream hits the maximum of a given host.wc-test passed