Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the concurrent configuration resolution error in Gradle 8 and above #996

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

bzzzzzz
Copy link
Contributor

@bzzzzzz bzzzzzz commented Apr 3, 2024

In Gradle 8, the build might sometimes fail if two or more projects attempt to resolve the same configuration of the third project simultaneously. In fact, reading from the configuration of other projects is considered a bad practice and will be prohibited starting from Gradle 9. To fix the products that fail with this issue in Gradle 8 and make plugin compatible with Gradle 9, this PR introduces a local proxy configuration that serves as a medium for accessing the configuration of the other projects.

Testing Done

  • local build ok
  • confirmed that this change fixes the projects that were failing before

@bzzzzzz bzzzzzz marked this pull request as ready for review April 3, 2024 19:26
@junchuanwang junchuanwang merged commit e7d0ee8 into linkedin:master Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants