Skip to content

ci: drop FranzDiebold/github-env-vars-action #9641 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ayesh
Copy link
Member

@Ayesh Ayesh commented Mar 18, 2025

This drops the FranzDiebold/github-env-vars-action in favor of native GH-Actions replacement patterns available.

ghcr.io (and other container registries for that matter) do not allow mix-case image names, so when a the repo is forked by a user with a mixed case username, or when reused in a repo with a mixed case repo name, the Docker image tagging step fails.

When a lowercase username is needed it is now dynamically bash-eval'd directly in the called line.

Notable replacements:

  • ${{ env.CI_REPOSITORY_OWNER_SLUG }}: $(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')
  • ${{ env.CI_REPOSITORY_NAME }}: ${{ github.event.repository.name }}

Related: #9639.

Proposed changes

  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

@Ayesh Ayesh force-pushed the fix/9641-github-envvars branch 2 times, most recently from 977407a to b116fe0 Compare March 18, 2025 18:05
@Ayesh Ayesh force-pushed the fix/9641-github-envvars branch from b116fe0 to 2554bef Compare March 18, 2025 19:07
This drops the `FranzDiebold/github-env-vars-action` in favor of native
GH-Actions replacement patterns available.

ghcr.io (and other container registries for that matter) do not allow
mix-case image names, so when a the repo is forked by a user with a
mixed case username, or when reused in a repo with a mixed case repo
name, the Docker image tagging step fails.

When a lowercase username is needed it is now dynamically bash-eval'd
directly in the called line.

Notable replacements:

 - `${{ env.CI_REPOSITORY_OWNER_SLUG }}`: `$(echo '${{ github.repository }}' | tr '[:upper:]' '[:lower:]')`
 - `${{ env.CI_REPOSITORY_NAME }}`: `${{ github.event.repository.name }}`

Related: [#9639](http://team.linkorb.com/cards/9639).
@Ayesh Ayesh force-pushed the fix/9641-github-envvars branch from 2554bef to 0e09641 Compare March 18, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant