Fix linode-cli linodes create
operation
#429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing an unrelated CLI change, I noticed this:
That's not good - the
linodes create
operation is missing manyparameters, including
type
andregion
that are required. After somedigging, I determined that it was because the
allOf
in/linodes/instances.post.requestBody.content.application/json.schema
section was not nested properly; the schema should be all of the
references
LinodeRequest
and the given properties. Having anallOf
alongsideproperties
isn't really correct (although it'sapparently not invalid).
Built off this spec, the CLI now see the full request:
I could be persuaded that the CLI's spec parser is incorrectly merging
the
allOf
with the same-levelproperties
, but I do not believe thisis the case. The OpenAPI Specification is light on details here, but
all examples using
allOf
do not include sibling nodes like this.