Skip to content

Conversation

bbiggerr
Copy link
Contributor

@bbiggerr bbiggerr commented Sep 22, 2023

Commands Added:

  • VPCs List
  • VPC Create
  • VPC View
  • VPC Update
  • VPC Delete
  • VPC Subnets List
  • VPC Subnet Create
  • VPC Subnet View
  • VPC Subnet Update
  • VPC Subnet Delete
  • Configuration Profile Interfaces List
  • Configuration Profile Interface Add
  • Configuration Profile Interface View
  • Configuration Profile Interface Update
  • Configuration Profile Interface Delete
  • Configuration Profile Interfaces Order

Commands Updated:

  • Linode Create
  • Linode Clone
  • Firewall Create
  • IPv4 Address Delete
  • IP Addresses Assign
  • IP Addresses Share
  • Support Ticket Request
  • User's Grants List
  • User's Grants Update
  • All commands with request and response bodies that include Interfaces.

Copy link

@mette-berger mette-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bbiggerr,
I have been part of designing and implementing the VPC API changes, but have not worked with the Linode API (or the api-docs) before.
Most of my comments are just suggestions and subtle nuances that we may not want to confuse the user with. I trust that you will know better than me what to include and what to skip. So feel very free to resolve those comments without making any changes.

Copy link

@mette-berger mette-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the last review I made we have changed some things in the API (earlier on we were not really sure we would be able to get them ready in time for the BETA release).
There are four changes.

  1. A new property with VPC info has been added to the GET JSON object from the /ntworking/ips and /linode/instances/:id/ips endpoints, see: API spec section on changes to existing endpoints

@wildmanonline wildmanonline merged commit 875be60 into linode:development Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants