Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test for LoadBalancer Service with 2 Ports #24

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Add Test for LoadBalancer Service with 2 Ports #24

merged 3 commits into from
Apr 16, 2019

Conversation

faem
Copy link

@faem faem commented Apr 11, 2019 •
edited
Loading

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@faem faem force-pushed the lka4 branch 6 times, most recently from 1dae9b5 to 83d55a2 Compare April 15, 2019 05:51
asauber
asauber approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

make sure to run make imports before committing

@asauber asauber merged commit 259693b into linode:master Apr 16, 2019
@asauber asauber mentioned this pull request Apr 16, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faem @asauber