-
Notifications
You must be signed in to change notification settings - Fork 79
proposal: Move all top-level methods to groups and correct documentation #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: Move all top-level methods to groups and correct documentation #252
Conversation
I just pushed up an implementation I'm much happier with. I'd love to hear some thoughts 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing locally! I think this is a much better structure for the project. It's less clunky and much easier to track down where changes should go. Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Once your change merged, I'll rebase it and refactor the obj group that I'm working on.
Thanks everyone! |
📝 Description
This change moves all top-level methods (
LinodeClient.nodebalancers(...)
, etc.) to groups to ensure consistency with the rest of the project. Additionally, alias methods have been created to prevent introducing any breaking changes and to ensure backwards compatibility.Top-level list methods are now implemented as
__call__(...)
methods for group classes, and create functions have been moved tocreate(...)
methods inside of each group.These groups have all been moved to a separate
groups
package which significantly reduces the size of thelinode_client
package.This change also introduces a few fixes for documentation issues:
✔️ How to Test
Testing refactor changes:
Testing docs changes: