Release v5.7.2 #319
Merged
Release v5.7.2 #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 📝 Description [IPv6 range view](https://www.linode.com/docs/api/networking/#ipv6-range-view__responses) and [IPv6 range list](https://www.linode.com/docs/api/networking/#ipv6-ranges-list__responses) actually share different response structures. The current `IPv6Range` object has been built based on the structure of IPv6 range list, so fields `linodes` and `is_bgp` are missing. To quickly fix it, I think simply adding these two fields to the `IPv6Range` object properties makes sense without introducing any breaking change. Otherwise we may consider create two separated objects for returning a single object and list, which is probably confusing for customers to use and more complicated for us to maintain. Any different idea is appreciated. ## ✔️ How to Test `tox`
zliang-akamai
approved these changes
Aug 21, 2023
lgarber-akamai
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.