Skip to content

test: Temporarily disable LDE integration tests #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

lgarber-akamai
Copy link
Contributor

@lgarber-akamai lgarber-akamai commented Jul 23, 2024

📝 Description

This PR temporarily disables LDE-related test logic while it is still not fully available. This change will be reverted in a follow-up ticket once LDE is confirmed to be available.

✔️ How to Test

The following test steps assume you have pulled down this PR locally and run make install.

Integration Tests

make TEST_COMMAND="models/linode/test_linode.py -k 'test_linode_with_disk_encryption_disabled or test_linode_rebuild'" testint

make TEST_COMMAND="models/lke/test_lke.py" testint

@lgarber-akamai lgarber-akamai marked this pull request as ready for review July 23, 2024 18:11
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner July 23, 2024 18:11
@lgarber-akamai lgarber-akamai requested review from ykim-akamai and yec-akamai and removed request for a team July 23, 2024 18:11
@lgarber-akamai lgarber-akamai added the testing for updates to the testing suite in the changelog. label Jul 23, 2024
@lgarber-akamai lgarber-akamai requested review from jriddle-linode and ezilber-akamai and removed request for ykim-akamai and yec-akamai July 23, 2024 18:11
@lgarber-akamai
Copy link
Contributor Author

@lgarber-akamai lgarber-akamai changed the title test: Temporarily disable LDE integration test: Temporarily disable LDE integration tests Jul 23, 2024
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM working locally.

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally!

@lgarber-akamai lgarber-akamai merged commit 536118a into linode:dev Jul 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants