Skip to content

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for the GET /networking/firewalls/{firewallId}/history/rules/{version} and GET /networking/firewalls/{firewallId}/history endpoints, and relevant tests.

✔️ How to Test

The following steps assume you have pulled down this PR locally.

Unit Tests

make test-unit

Integration Tests

make test-int TEST_CASE=test_get_networking_rule_versions

@ezilber-akamai ezilber-akamai added the new-feature for new features in the changelog. label Mar 7, 2025
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner March 7, 2025 18:26
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team March 7, 2025 18:26
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally.

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, nice work!

@ezilber-akamai ezilber-akamai merged commit 70169d7 into linode:dev Mar 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants