Rename streamingInitialRoundIterators to streamingGroundingIterators and allow instantiation of streamingCacheIterators with typed StreamingTermStores. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation in SGD and DCD reasoning.
This option was only necessary for a very specific test in the online psl icml 2021 submission.
Override hashcode and equals method of predicates. This will allow for equals checks to be made when predicates are sent over the wire.
…streamingTermStores. Introduce method and default implementation of reject cache term for streamingTermStores.
…hod for deletinig atom from all partitions.
…and allow instantiation of streamingCacheIterators with typed StreamingTermStores.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the changes made in the larger onlinePSL project.
Rename streamingInitialRoundIterators to streamingGroundingIterators and allow instantiation of streamingCacheIterators with typed StreamingTermStores.
The renaming of the classes is to reflect that these iterators will not only be used in the initial round of inference but will also be used for grounding which can happen many times in the online setting.
Then allowing instantiation of streamingCacheIterators with typed StreamingTermStores is so onlineTermStores (which extend StreamingTermStores) can also be used to instantiate the iterators.