Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OnlineInference applications, OnlineClients, and OnlineServers. #310

Merged
merged 76 commits into from
Aug 7, 2021

Conversation

dickensc
Copy link
Contributor

@dickensc dickensc commented Jul 8, 2021

This is a part of the changes made in the larger onlinePSL project.

Introduce OnlineInference applications, OnlineClients, and OnlineServers.
This version of OnlineInference only supports Exits and Stops.
Online test utilities and an SGDOnlineInference application test are also introduced.
Currently, the testing infrastructure only tests to see that SGDOnlineInference applications start, will accept client connections, and will shut down cleanly.

This option was only necessary for a very specific test in the online psl icml 2021 submission.
Copy link
Member

@eriq-augustine eriq-augustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good.
I am not seeing anything that would require big structural change.

I should have mentioned this during a previous review, but can you add a timestamp (a long is fine) to OnlineMessage.

@eriq-augustine
Copy link
Member

lgtm!

@eriq-augustine eriq-augustine merged commit 9e406ea into linqs:develop Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants