Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online delete atoms. #326

Merged
merged 130 commits into from
Nov 18, 2021
Merged

Online delete atoms. #326

merged 130 commits into from
Nov 18, 2021

Conversation

dickensc
Copy link
Contributor

Use the return value of deleteAtom call to delete atoms in Online terms. The current implementation always provides null to the online termstore and this could lead to duplicated terms.

This option was only necessary for a very specific test in the online psl icml 2021 submission.
@eriq-augustine
Copy link
Member

lgtm

@eriq-augustine eriq-augustine merged commit e290599 into linqs:develop Nov 18, 2021
@dickensc dickensc deleted the OnlineDeleteAtoms branch February 25, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants