Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct eslint version is being used. #397

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Ensure correct eslint version is being used. #397

merged 2 commits into from
Oct 26, 2022

Commits on Oct 26, 2022

  1. Ensure correct eslint version is being used. 

    As of 4.0.0 we require `eslint@^8.4.0` (and properly included that as a
non-optional peer dependency), but unfortunately (depending on your
package manager) the peer dependency isn't enforced.

This brings in
[validate-peer-dependencies](https://github.com/rwjblue/validate-peer-dependencies)
and runs it when the formatter is required/loaded. This will emit a
helpful error if your `eslint` version isn't compliant with our peer
dependency requirements.
    @rwjblue
    rwjblue committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    bf20ceb View commit details
    Browse the repository at this point in the history

  2. Move eslint from dependencies -> devDependencies

    @rwjblue
    rwjblue committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c78a6fa View commit details
    Browse the repository at this point in the history