Skip to content
This repository has been archived by the owner on Apr 27, 2018. It is now read-only.

Do we still need ExtractLinksAndText? #176

Closed
lintool opened this issue Nov 25, 2015 · 4 comments
Closed

Do we still need ExtractLinksAndText? #176

lintool opened this issue Nov 25, 2015 · 4 comments
Assignees
@lintool
Labels
cleanup

Comments

@lintool
Copy link
Owner

lintool commented Nov 25, 2015

Do we still need the Scala UDF ExtractLinksAndText? It seems like everything we need is already supported by the ExtractLinks UDF.
@lintool lintool changed the title Do we still need ExtractLinksAndText Do we still need ExtractLinksAndText? Nov 25, 2015
@aliceranzhou
Copy link
Collaborator

No, we do not. Shall I remove it?

On Tue, Nov 24, 2015 at 9:01 PM Jimmy Lin notifications@github.com wrote:

Do we still need the Scala UDF ExtractLinksAndText? It seems like
everything we need is already supported by the ExtractLinks UDF.

—
Reply to this email directly or view it on GitHub
#176.

@lintool
Copy link
Owner Author

lintool commented Nov 25, 2015

It's okay, I'll do it as part of my cleanup pass...

@lintool lintool self-assigned this Nov 25, 2015
@aliceranzhou
Copy link
Collaborator

Okay, thank you Prof. Jimmy!

On Tue, Nov 24, 2015 at 9:23 PM Jimmy Lin notifications@github.com wrote:

It's okay, I'll do it as part of my cleanup pass...

—
Reply to this email directly or view it on GitHub
#176 (comment).

lintool added a commit that referenced this issue Nov 25, 2015
@lintool
Killed RecordUtils, ExtractLinksAndText, JwatArcLoaderTest (Issues #172…
26d2ef5 
…, #173, #176)
@lintool
Copy link
Owner Author

lintool commented Nov 25, 2015

Fixed commit 26d2ef5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lintool lintool

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lintool @ianmilligan1 @aliceranzhou