Use firmware path from sysfs #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradybcio
reviewed
Mar 21, 2024
konradybcio
reviewed
Mar 21, 2024
|
looks good at first sight, left some minor comments |
lumag
reviewed
Mar 21, 2024
| strcat(path, "/"); | ||
| strcat(path, dirname(firmware_value)); | ||
| strcat(path, "/"); | ||
| strcat(path, file); |
There was a problem hiding this comment.
This looks like a perfect usecase for asprintf
There was a problem hiding this comment.
asprintf/vasprintf is non-standard GNU/BSD extension and existing code around already uses strcpy/strcat everywhere. I can try though to use it here if you insist
Some linux distributions adjust path fro kernel to load firmware from using /sys/module/firmware_class/parameters/path. Kernel supports it, teach tqftpserv to respect it too. Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
minlexx
force-pushed
the
respect-firmware-sysfs-path
branch
from
c58ac26
to
a4c755d
Compare
lumag
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some linux distributions adjust path fro kernel to load firmware from using
/sys/module/firmware_class/parameters/path. Kernel supports it, teach tqftpserv to respect it too.Kernel supports only single firmware path specified in firmware_class path. In postmarketOS we created a service script msm-firmware-loader that runs in early boot stage and symlinks all firmware it can find on various device partitions into a single directory, which is then written into
/sys/module/firmware_class/parameters/path.With this patch tqftpserv is able, for example, to successfully serve
wlanmdsp.mbnfile when modem remoteproc is started.Can be used to solve #7