tests: build: run baseline build for Kconfig updates #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Kconfig updates may result in .config changes which may in turn alter the preprocessor output of header files, which may in turn result in file rebuilds. Due to the incremental way in which these tests may be run over a patchset this can result in inaccurate incumbent warning counts for patches, other than the first patch in a series for which a baseline build already occurs. This can, in turn, lead to false positives about new warnings being introduced. Some discussion of this problem can be found at: - Re: [PATCH v3 08/12] testing: net-drv: add basic shaper test https://lore.kernel.org/netdev/20240808122042.GA3067851@kernel.org/ While possibly heavy handed, the solution in this patch does seem address the problem. And can always be improved upon later. Signed-off-by: Simon Horman <horms@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Kconfig updates may result in .config changes which may in turn alter the preprocessor output of header files, which may in turn result in file rebuilds.
Due to the incremental way in which these tests may be run over a patchset this can result in inaccurate incumbent warning counts for patches, other than the first patch in a series for which a baseline build already occurs. This can, in turn, lead to false positives about new warnings being introduced.
Some discussion of this problem can be found at:
While possibly heavy handed, the solution in this patch does seem address the problem. And can always be improved upon later.