contest: vmksft-p: parse time from nested tests #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to follow the specs. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
kuba-moo
requested changes
Aug 21, 2024
It is a useful info to display if it is available. For the moment, I think only mptcp_connect.sh adds such info. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
KTAP is clear about the 'SKIP' directive and the result [1]: > note the result of the test case result line can be either "ok" or > "not ok" if the SKIP directive is used Nothing seems to be imposed on TAP 13/14 side [2], so I suppose it is fine. We can then drop this restriction, and mark the test as 'skipped' if the directive is starting with 'skip'. Link: https://docs.kernel.org/dev-tools/ktap.html#test-case-result-lines [1] Link: https://testanything.org/tap-version-14-specification.html [2] Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
matttbe
force-pushed
the
vmksft-p-subtests-time
branch
from
3f403a8 to
0d77492
Compare
kuba-moo
added a commit
to linux-netdev/testing
that referenced
this pull request
Sep 10, 2024
Matthieu Baerts says: ==================== selftests: mptcp: add time per subtests in TAP output Patches here add 'time=<N>ms' in the diagnostic data of the TAP output, e.g. ok 1 - pm_netlink: defaults addr list # time=9ms This addition is useful to quickly identify which subtests are taking a longer time than the others, or more than expected. Note that there are no specific formats to follow to show this time according to the TAP 13, TAP 14 and KTAP specifications, but we follow the format being parsed by NIPA [1]. Patch 1 modifies mptcp_lib.sh to add this support to all MPTCP selftests. Patch 2 removes the now duplicated info in mptcp_connect.sh Patch 3 slightly improves the precision of the first subtests in all MPTCP subtests. Patches 4 and 5 remove duplicated spaces in TAP output, for the TAP parsers that cannot handle them properly. v1: https://lore.kernel.org/20240902-net-next-mptcp-ksft-subtest-time-v1-0-f1ed499a11b1@kernel.org Link: linux-netdev/nipa#36 ==================== Link: https://patch.msgid.link/20240906-net-next-mptcp-ksft-subtest-time-v2-0-31d5ee4f3bdf@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a useful info to display if it is available.
For the moment, I think only mptcp_connect.sh adds such info.