Cannot detect sensors

[oliviertilmans]

Hello,

My setup: MBP9.1 -- Linux oli-laptop 3.15.1-1-ARCH #1 SMP PREEMPT Tue Jun 17 09:32:20 CEST 2014 x86_64 GNU/Linux

There are no tempX_* files under /sys/devices/platform/coretemp.0/ ; which results in:

$ sudo mbpfan -f -v
Writing a new .pid file with value 7738 at: /var/run/mbpfan.pid
mbpfan[7738]: Writing a new .pid file with value 7738 at: /var/run/mbpfan.pid
Successfully written a new .pid file with value 7738 at: /var/run/mbpfan.pid
mbpfan[7738]: Successfully written a new .pid file with value 7738 at: /var/run/mbpfan.pid
Couldn't open configfile, using defaults
Found 0 sensors
Found 2 fans
Sleeping for 7 seconds
Old Temp 0: New Temp: 0, Fan Speed: 2000
Sleeping for 7 seconds
Old Temp 0: New Temp: 0, Fan Speed: 2000
[...]

Instead they are under /sys/devices/platform/coretemp.0/hwmon/hwmon1/ (and I guess more generally they would be in hwmonX if I had multiple CPU's)

I patched for my case, but have no idea if that applies for other distrib/laptop

oliviertilmans@e2b1aef

Which results in

sudo ./bin/mbpfan -f -v
Writing a new .pid file with value 7740 at: /var/run/mbpfan.pid
mbpfan[7740]: Writing a new .pid file with value 7740 at: /var/run/mbpfan.pid
Successfully written a new .pid file with value 7740 at: /var/run/mbpfan.pid
mbpfan[7740]: Successfully written a new .pid file with value 7740 at: /var/run/mbpfan.pid
Couldn't open configfile, using defaults
Found 5 sensors
Found 2 fans
Sleeping for 7 seconds
Old Temp 69: New Temp: 68, Fan Speed: 2000
Sleeping for 7 seconds

[Yamakaky]

I have the same problem on archlinux, I will try your patch later.

[gdamjan]

Why not use /sys/class/hwmon/hwmon* ?

[oliviertilmans]

No particular reason,
I noticed that the symlinks in /sys/class/hwmon/hwmon* were resolving to different subdirs, and that only one of them was for coretemp so I used it directly.

ls -o /sys/class/hwmon
total 0
lrwxrwxrwx 1 root 0 Jun 19 12:25 hwmon0 -> ../../devices/platform/applesmc.768/hwmon/hwmon0
lrwxrwxrwx 1 root 0 Jun 19 12:25 hwmon1 -> ../../devices/platform/coretemp.0/hwmon/hwmon1

[dgraziotin]

Hey folks,

After so much time without a mbp, I have just received a MacBookPro11,1 from my faculty. I will install GNU/Linux on it as soon as I can, and I will investigate the issue. While I have not checked any source, I am afraid that mbpfan will likely need to support both legacy hardware/kernel and new hardware/kernel. Does anybody know if the new sensor paths are caused by an update to the Linux kernel, or is it because of the new mbp models? Or both? :-)

[Yamakaky]

It's a kernel update, I just tested. I think the best option is to detect at runtime which of the new and old location is available, with a preference for the new one. The patch works for me. Does someone know why the pseudo-files were renamed ?

[benjaminbauer]

Did not try the patch yet, but I can confirm that since linux 3.15, my fans won't work any more.

Intel(R) Core(TM) i7-2675QM CPU @ 2.20GHz

[dgraziotin]

This discussion on the linux kernel mailing list confirms that the change was introduced in linux 3.15. The discussions in there provided the suggestion to use libsensors. I will explore this possibility when I develop the next mbpfan release.

[Yamakaky]

Maybe a temporary fix before ? Like checking which of the two files exists ?

[dgraziotin]

Yup, I will definitely do that before!

[dgraziotin]

@oliviertilmans @Yamakaky @benjaminbauer @gdamjan could you all please comment here answering the following items?

1. Macbook Model (e.g., 11,1)
2. Distro/kernel (but I guess you are all using Arch and 3.15)
3. The output of ls -al /sys/devices/platform/coretemp.0/hwmon/
4. The output of ls -al /sys/devices/platform/coretemp.0/hwmon/hwmon1 (and other hwmonX if present?)

While I am finding the time to install GNU/Linux on the mbp they gave me, I can still sketch a fix based on your answers. Thank you!

[Yamakaky]

macbook pro 9.1 I think, beginning of 2011
Archlinux, linux 3.15
http://0bin.net/paste/wTd4CeVXNkAuwIN7#Tqi+8MJOvD/xPd48100wwKnniiQFczzxpTplLSYNq04=

[oliviertilmans]

1. $ sudo dmidecode -s system-product-name

   MacBookPro9,1

2. Arch Linux/$ uname -r

   3.15.1-1-ARCH

3. http://goo.gl/0Q7usi

[dgraziotin]

Ok, I wrote a quick fix. Download this, open src/mbpfan.c at line 95, and change hwmon0 to hwmon1.

This change is tailored to your macbook pro model. My mbp 11,1 uses hwmon0 instead. I need to write a new solution, which scans /sys/devices/platform/coretemp.0/hwmon/ for hwmonX folders, before actually entering them and scanning for the sensors. Meanwhile, the fix should work.

[benjaminbauer]

@dgraziotin

1. MacBookPro8,2
2. Arch 3.15
3. drwxr-xr-x 3 root root 0 Jun 22 11:58 hwmon0
4. $ ls -al /sys/devices/platform/coretemp.0/hwmon/hwmon0:

total 0
drwxr-xr-x 3 root root    0 Jun 22 12:04 .
drwxr-xr-x 3 root root    0 Jun 22 12:04 ..
lrwxrwxrwx 1 root root    0 Jun 22 12:05 device -> ../../../coretemp.0
-r--r--r-- 1 root root 4096 Jun 22 12:05 name
drwxr-xr-x 2 root root    0 Jun 22 12:05 power
lrwxrwxrwx 1 root root    0 Jun 22 12:05 subsystem -> ../../../../../class/hwmon
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp1_crit
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp1_crit_alarm
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp1_input
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp1_label
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp1_max
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp2_crit
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp2_crit_alarm
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp2_input
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp2_label
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp2_max
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp3_crit
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp3_crit_alarm
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp3_input
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp3_label
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp3_max
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp4_crit
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp4_crit_alarm
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp4_input
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp4_label
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp4_max
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp5_crit
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp5_crit_alarm
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp5_input
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp5_label
-r--r--r-- 1 root root 4096 Jun 22 12:05 temp5_max
-rw-r--r-- 1 root root 4096 Jun 22 11:58 uevent