Skip to content

Conversation

ahyangyi
Copy link

@ahyangyi ahyangyi commented Jul 7, 2014

1: Fix makefile: no redundant sudo in the command line. That makes no difference for everyone since the sudo is redundant, and fixes the bug for myself since I do not use sudo.

  1. Fix mbpfan.c: no more sudden silence if you start this daemon when your system is already very hot. This is due to a 7-second delay between the starting of this daemon and the first change fan speed command. I feel this too dangerous since I was running this with CPU temperature at 92 degree and had to wait for that 7 seconds praying that it won't hit 100 during this....

@ahyangyi
Copy link
Author

ahyangyi commented Jul 7, 2014

Oh I just committed another patch that prompts Gentoo users to chmod +x the init script.

@dgraziotin
Copy link
Collaborator

Hi, thanks! I think your changes to mbpfan.c make sense. If any, I should also delete lines 497-505. As soon as I can access to my machine again, I will test the changes and merge them. Cheers.

@dgraziotin dgraziotin merged commit 451bbb9 into linux-on-mac:master Jul 27, 2014
@dgraziotin
Copy link
Collaborator

I have merged your pull request (thank you). However, I did a small edit. Instead of completely deleting the first sleep(), I make mbpfan sleep for 2 seconds only. This is for correctly detecting high temperatures. A no sleep would make mbpfan fail in cases for old_temp=61 new_temp=61. A small wait helps mbpfan detect the change. I think it does a better job now, and it is something between the previous solution and your solution. Thank you again, this happened because of your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants