docs: Add note about using previous: replaced and temporary service failures #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 53.39% 53.39%
=======================================
Files 2 2
Lines 796 796
=======================================
Hits 425 425
Misses 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
richm
force-pushed
the
readme-reset-loses-connection
branch
from
56027af
to
f86e074
Compare
erig0
reviewed
Apr 26, 2023
README.md
Outdated
| *WARNING*: When using this option, there's a small time window when firewall is | ||
| being reset and all new connections to the system are rejected. Applying changes | ||
| with this option in production might cause temporary service failures during the | ||
| operation. |
There was a problem hiding this comment.
Might be worth adding that existing connections will still pass traffic.
There was a problem hiding this comment.
please see the new text
…ailures Add a note to the README about the use of `previous: replaced` and that it can cause temporary service outages to the node being managed. linux-system-roles#138
richm
force-pushed
the
readme-reset-loses-connection
branch
from
f86e074
to
bb9acf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to the README about the use of
previous: replacedand that it cancause temporary service outages to the node being managed.
#138