[2.3] Test `lcov/extract/extract.sh` seen fail with "did not find expected context field"

[hartwork]

test.log for download here (I hope it doesn't contain anything sensitive, please notify me if it does 🙏 )

Am I doing something wrong?:

# make -j5 -j1 check 
Creating coverage files (2 tests, 5 source files)
  Source tree ......... done (950 lines, 50 functions, 3428 branches)
  Full coverage ....... done
  Target coverage ..... done
  Partial coverage .... done
  Zero coverage ....... done
Starting tests
genhtml/full.sh ................... [pass] (time 0.8s, mem 48.8MB)
genhtml/zero.sh ................... [pass] (time 0.8s, mem 48.9MB)
genhtml/demangle.sh ............... [pass] (time 2.2s, mem 40.7MB)
genhtml/relative/relative.sh ...... [pass] (time 0.5s, mem 40.9MB)
genhtml/lambda/lambda.sh .......... [pass] (time 3.8s, mem 122.7MB)
lcov/add/zero.sh .................. [pass] (time 0.7s, mem 39.5MB)
lcov/add/zero2.sh ................. [pass] (time 1.1s, mem 44.3MB)
lcov/add/full.sh .................. [pass] (time 0.7s, mem 39.7MB)
lcov/add/full2.sh ................. [pass] (time 1.2s, mem 44.5MB)
lcov/add/prune.sh ................. [pass] (time 1.5s, mem 35.8MB)
lcov/add/track.sh ................. [pass] (time 0.4s, mem 35.2MB)
lcov/misc/help.sh ................. [pass] (time 0.3s, mem 34.5MB)
lcov/misc/version.sh .............. [pass] (time 0.3s, mem 34.5MB)
lcov/summary/zero.sh .............. [pass] (time 0.8s, mem 39.2MB)
lcov/summary/full.sh .............. [pass] (time 0.7s, mem 39.5MB)
lcov/extract/extract.sh ........... [fail] (time 5.1s, mem 59.5MB)
    Skipping 228 previous lines (see /var/tmp/portage/dev-util/lcov-2.3/work/lcov-2.3/tests//test.log)
    ...
      functions...: 28.6% (2 of 7 functions)
      branches....: 33.3% (8 of 24 branches)
    Filter suppressions:
      region:
        2 instances
        5 coverpoints
    Message summary:
      no messages were reported
    Error:  did not find expected context field
  EXITCODE ...: 1
make[3]: *** [../../common.mak:116: check] Error 1
make[2]: *** [../common.mak:116: check] Error 1
16 tests executed, 15 passed, 1 failed, 0 skipped (time 21.7s, mem 748.6MB)
Result log stored in /var/tmp/portage/dev-util/lcov-2.3/work/lcov-2.3/tests/test.log
make[1]: *** [common.mak:116: check] Error 1
make: *** [Makefile:262: check] Error 2

[henry2cox]

Interesting. Passes in github system.
Do you have the rundir - in particular, the 'context.info.json' file from the .../lcov/extract rundir?
What user was this running as? This part of the test is just checking if the 'user' field got saved as expected - so either it did not get saved or the content is not what was expected - or maybe the command being used is not sufficiently portable.

[hartwork]

Interesting. Passes in github system. Do you have the rundir - in particular, the 'context.info.json' file from the .../lcov/extract rundir?

@henry2cox it's not from the very same run, but from one failing with the same output: context.info.json

What user was this running as? This part of the test is just checking if the 'user' field got saved as expected - so either it did not get saved or the content is not what was expected - or maybe the command being used is not sufficiently portable.

I used an unprivileged "regular" user, but there may be some Gentoo sandboxing involved.

[henry2cox]

What value do you see in $USER, in your shell on that machine?
Given json content, test is expecting 'sping' (without quotes).

This section is just trying to test that context callback occurred, and did what was expected...

[hartwork]

@henry2cox I confirm, yes, I see that value for ${USER}.

[henry2cox]

Hmm.
The grep -E .. isn't matching.
Not sure why.
Pattern is simple and doesn't need to be RE.. can simply to make test pass

But we don't see that behaviour on other platforms. Odd.

[hartwork]

I also do not see it yet outside of packaging.

[henry2cox]

Can you describe your configuration and environment:

• which version of lcov code? Checked out from github? Unpacked from release tarball? Something else?
• is your tests directory a git repo/part of a git repo?

[hartwork]

@henry2cox I confirm, yes, I see that value for ${USER}.

@henry2cox need to correct myself here^^, something in packaging is taking away ${USER}, probably for good reason. So the reproducer is this:

USER= make -C tests/lcov/extract/ check

I have created pull request #383 now with a candidate fix.

[hartwork]

@henry2cox PS: For completeness:

Can you describe your configuration and environment:

• which version of lcov code? Checked out from github? Unpacked from release tarball? Something else?

Both latest from Git — the 9999 ebuild — or 2.3 from release tarball.

• is your tests directory a git repo/part of a git repo?

The path is /var/tmp/portage/dev-util/lcov-2.3/work/lcov-2.3/ and there is Git repository above or below.