Fix the case when step generates an error which is passed to a step state, but test runner exits first

[rihter007]

The test logs are:

time="2022-08-07T18:51:48Z" level=debug msg="monitor: active" file="test_runner.go:447"
time="2022-08-07T18:51:48Z" level=debug msg="monitor: starting at step [#0 Step1]" file="test_runner.go:449"
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 1: current step [#0 Step1]" file="test_runner.go:462"
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 1: [#0 Step1]: [Target{ID: "TExtra"} 0 init false ]" file="test_runner.go:466"
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 1: [#0 Step1]: not all targets injected yet ([Target{ID: "TExtra"} 0 init false ])" file="test_runner.go:471"
time="2022-08-07T18:51:48Z" level=debug msg="[Target{ID: "TExtra"} 0 init false ]: target handler active" file="test_runner.go:326" target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="[Target{ID: "TExtra"} 0 begin false ]: injecting into [#0 Step1]" file="test_runner.go:365" target=TExtra
time="2022-08-07T18:51:48Z" level=info msg="Obtained '{Target{ID: "TExtra"} }' for target 'TExtra'" file="step_runner.go:329" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=info msg="Obtained '{Target{ID: "TExtra2"} }' for target 'TExtra2'" file="step_runner.go:329" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=error msg="err: test step Step1 returned unexpected result for TExtra2" file="step_runner.go:436" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="Reading loop finished" file="step_runner.go:143" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="Got target result: ''" file="test_runner.go:382" target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="[Target{ID: "TExtra"} 0 end true ]: target handler finished" file="test_runner.go:322" target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 2: current step [#0 Step1]" file="test_runner.go:462"
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 2: [#0 Step1]: [Target{ID: "TExtra"} 0 end true ]" file="test_runner.go:466"
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 2: [#0 Step1]: no more targets, closing input channel" file="test_runner.go:485"
time="2022-08-07T18:51:48Z" level=debug msg="monitor pass 0: [Target{ID: "TExtra"} 0 end true ]" file="test_runner.go:509"
time="2022-08-07T18:51:48Z" level=debug msg="monitor: finished, " file="test_runner.go:525"
time="2022-08-07T18:51:48Z" level=debug msg="waiting for step runners to finish" file="test_runner.go:283"
time="2022-08-07T18:51:48Z" level=debug msg="cancel target handlers" file="test_runner.go:203"
time="2022-08-07T18:51:48Z" level=debug msg="leaving, err test step Step1 returned unexpected result for TExtra2, target states:" file="test_runner.go:214"
time="2022-08-07T18:51:48Z" level=debug msg=" 0 target: '[Target{ID: "TExtra"} 0 end true ]' step err: '', resume ok: 'false'" file="test_runner.go:236"
time="2022-08-07T18:51:48Z" level=debug msg="- 0 in flight, ok to resume? false" file="test_runner.go:238"
time="2022-08-07T18:51:48Z" level=debug msg="step states:" file="test_runner.go:239"
time="2022-08-07T18:51:48Z" level=debug msg=" 0 [#0 Step1] true %!t() " file="test_runner.go:241"
--- FAIL: TestTestRunnerSuite (2.43s)
--- FAIL: TestTestRunnerSuite/TestStepYieldsResultForNonexistentTarget (0.01s)
test_runner_test.go:373:
Error Trace: /go/src/github.com/linuxboot/contest/pkg/runner/test_runner_test.go:373
Error: Not equal:
expected: "\n{[1 1 SimpleTest 0 Step1][(*Target)(nil) TestError &"\"test step Step1 returned unexpected result for TExtra2\""]}\n"
actual : "\n\n"

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,3 @@
        	            	 
        	            	-{[1 1 SimpleTest 0 Step1][(*Target)(nil) TestError &"\"test step Step1 returned unexpected result for TExtra2\""]}
        	            	 
        	            	+
        	Test:       	TestTestRunnerSuite/TestStepYieldsResultForNonexistentTarget

time="2022-08-07T18:51:48Z" level=debug msg="TestStep finished '', rs: ''" file="step_runner.go:417" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="output channel closed" file="step_runner.go:397" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="Running loop finished" file="step_runner.go:137" step_index=0 step_label=Step1 target=TExtra
time="2022-08-07T18:51:48Z" level=debug msg="StepRunner finished" file="step_runner.go:129" step_index=0 step_label=Step1 target=TExtra

[codecov-commenter]

Codecov Report

Merging #121 (b3a0339) into main (927ea7f) will increase coverage by 0.05%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   63.85%   63.90%   +0.05%     
==========================================
  Files         163      163              
  Lines       10170    10179       +9     
==========================================
+ Hits         6494     6505      +11     
+ Misses       2980     2979       -1     
+ Partials      696      695       -1     

Flag	Coverage Δ
e2e	50.24% <62.50%> (-0.01%)	⬇️
integration	55.71% <93.75%> (+0.05%)	⬆️
unittests	49.27% <87.50%> (+0.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/runner/step_state.go	93.61% <93.33%> (+3.02%)	⬆️
pkg/runner/test_runner.go	93.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.