Parameter.Expand consumes optional StepsVariables argument #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihter007
force-pushed
the
feature/expand_variables_to_parameters
branch
from
ff23a80 to
263cd19
Compare
rihter007
force-pushed
the
feature/expand_variables_to_parameters
branch
from
263cd19 to
04c951a
Compare
mimir-d
requested changes
Aug 8, 2022
| return mapCopy | ||
| } | ||
|
|
||
| func registerStepVariableAccessor(fm map[string]interface{}, tgtID string, vars StepsVariablesReader) { |
There was a problem hiding this comment.
dont these always expand to a string? the descriptor json is a string, what's the point of having an int version? just type safety?
There was a problem hiding this comment.
No, always to "smth" or "smth" and error: https://pkg.go.dev/text/template#FuncMap . Where smth should will be converted to string by template (I assume via Sprintf)
Signed-off-by: Ilya <rihter007@inbox.ru>
rihter007
force-pushed
the
feature/expand_variables_to_parameters
branch
from
04c951a to
642b26f
Compare
mimir-d
approved these changes
Aug 8, 2022
rihter007
pushed a commit
that referenced
this pull request
Aug 9, 2022
…rameters Parameter.Expand consumes optional StepsVariables argument Signed-off-by: Ilya <rihter007@inbox.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal change to make step variables feature fully work in prod